Date: Wed, 11 Dec 2002 17:44:18 -0800 (PST) From: Nate Lawson <nate@root.org> To: Ian Dowse <iedowse@maths.tcd.ie> Cc: Alexander Langer <alex@big.endian.de>, Patrick Soltani <psoltani@ultradns.com>, freebsd-hackers@FreeBSD.ORG, luigi@FreeBSD.ORG Subject: Re: panic: icmp_error: bad length Message-ID: <Pine.BSF.4.21.0212111657460.31267-100000@root.org> In-Reply-To: <200212120054.aa55340@salmon.maths.tcd.ie>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 12 Dec 2002, Ian Dowse wrote:
> --- ip_fw.c 21 Nov 2002 01:27:30 -0000 1.131.2.38
> +++ ip_fw.c 12 Dec 2002 00:43:22 -0000
> @@ -1573,6 +1573,11 @@
> break;
> }
> default: /* Send an ICMP unreachable using code */
> + /* Must convert to host order for icmp_error(). */
> + if (BRIDGED) {
> + NTOHS(ip->ip_len);
> + NTOHS(ip->ip_off);
> + }
> icmp_error(*m, ICMP_UNREACH,
> f->fw_reject_code, 0L, 0);
> *m = NULL;
Since the REJECT case needs several headers in host order, why not put
this there (line 1546), taking care of potential problems in the tcp RST
case?
-Nate
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0212111657460.31267-100000>