Date: Mon, 21 Feb 2005 18:13:07 +0100 From: Max Laier <max@love2party.net> To: Divacky Roman <xdivac02@stud.fit.vutbr.cz> Cc: current@freebsd.org Subject: Re: panic in altq Message-ID: <200502211813.14525.max@love2party.net> In-Reply-To: <20050221154738.GA64629@stud.fit.vutbr.cz> References: <20050221154738.GA64629@stud.fit.vutbr.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart2685896.PUHvAU7OLz
Content-Type: text/plain;
charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
On Monday 21 February 2005 16:47, Divacky Roman wrote:
> I was seeing panics on boot when pf was enabled.
> this patch:
>
> Index: altq_subr.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /home/ncvs/src/sys/contrib/altq/altq/altq_subr.c,v
> retrieving revision 1.5
> diff -u -r1.5 altq_subr.c
> --- altq_subr.c 15 Jun 2004 23:59:37 -0000 1.5
> +++ altq_subr.c 21 Feb 2005 15:44:21 -0000
> @@ -93,7 +93,7 @@
> int (*altq_input)(struct mbuf *, int) =3D NULL;
> static struct mbuf *tbr_dequeue(struct ifaltq *, int);
> static int tbr_timer =3D 0; /* token bucket regulator timer */
> -static struct callout tbr_callout =3D CALLOUT_INITIALIZER;
> +static struct callout tbr_callout;
>
> #ifdef ALTQ3_CLFIER_COMPAT
> static int extract_ports4(struct mbuf *, struct ip *, struct flowinfo_in
> *); @@ -155,6 +155,7 @@
> void *(*classify)(void *, struct mbuf *, int);
> {
> IFQ_LOCK(ifq);
> + callout_init(&tbr_callout, 0);
> if (!ALTQ_IS_READY(ifq)) {
> IFQ_UNLOCK(ifq);
> return ENXIO;
>
>
> it completly solves (it used illegaly initialized callout, dunno hows
> possible it worked before)
>
> I hope for commiting this
Done with changes. Thanks for the report.
=2D-=20
/"\ Best regards, | mlaier@freebsd.org
\ / Max Laier | ICQ #67774661
X http://pf4freebsd.love2party.net/ | mlaier@EFnet
/ \ ASCII Ribbon Campaign | Against HTML Mail and News
--nextPart2685896.PUHvAU7OLz
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (FreeBSD)
iD8DBQBCGhaqXyyEoT62BG0RAqM5AJ0YQ5cbAW/mbXcCAuIMhBG1+FOqnwCfa3ve
YBEhCu3iucblrvTWPg+chnM=
=Anwi
-----END PGP SIGNATURE-----
--nextPart2685896.PUHvAU7OLz--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200502211813.14525.max>