Date: Tue, 4 Sep 2001 19:16:11 +0300 (EEST) From: Maxim Sobolev <sobomax@FreeBSD.ORG> To: Konstantin.Chuguev@dante.org.uk (Konstantin Chuguev) Cc: sobomax@FreeBSD.ORG (Maxim Sobolev), phk@critter.freebsd.dk (Poul-Henning Kamp), brent@rcfile.org (Brent Verner), current@FreeBSD.ORG, hackers@FreeBSD.ORG Subject: Re: Junior Kernel Hacker task: improve vnode->v_tag Message-ID: <200109041616.f84GGC898315@vega.vega.com> In-Reply-To: <no.id> from "Konstantin Chuguev" at Sep 04, 2001 04:50:13 PM
next in thread | previous in thread | raw e-mail | index | archive | help
> > Hi Maxim, > > Perhaps you meant: > diff -d -u -r1.154 vnode.h > --- sys/vnode.h 2001/08/27 06:09:55 1.154 > +++ sys/vnode.h 2001/09/04 15:21:25 > @@ -175,6 +175,7 @@ > /* open for business 0x100000 */ > #define VONWORKLST 0x200000 /* On syncer work-list */ > #define VMOUNT 0x400000 /* Mount in progress */ > +#define VLOCKABLE 0x600000 /* vnode supports locking */ > ...should be ^^^^^^^^ > +#define VLOCKABLE 0x800000 /* vnode supports locking */ Indeed. Thank you for pointing out! -Maxim > > > > Maxim Sobolev wrote: > > > > In message <200109041343.f84DhO097646@vega.vega.com>, Maxim Sobolev writes: > > > >> > > > >> In message <20010904081337.A8968@rcfile.org>, Brent Verner writes: > > > >> > > > > >> >I've done a /cursory/ look over how this v_tag is used. I'm not sure > > > >> >this is a simple/clean as you propose, since this is used in the > > > >> >IS_LOCKING_VFS macro, as well as in union_subr.c... > > > >> > > > > Well, that is just too bad, because IS_LOCKING_VFS is wrong then. > > > >> > > > >> The places which inspect v_tag will have to be changed to use > > > >> strcmp() then... > > > > > > > >I think that we can add a new vnode flag, say VCANLOCK, so that each > > > >particular VFS can set it if it supports locking, which should allow > > > >to remove pre-defined VFS list from the IS_LOCKING_VFS macro. I can > > > >produce a patch if it sounds reasonably. > > > > > > Yeah, I think that makes a lot of sense. > > > > See attached. Please let me know if it is OK for you. > > > > -Maxim > > > > ---------------------------------------------------------------------- > > Name: p > > p Type: Plain Text (text/plain) > > Encoding: 7bit > > Description: ASCII C program text > > -- > * * Konstantin Chuguev Francis House > * * Application Engineer 112 Hills Road > * Tel: +44 1223 302992 Cambridge CB2 1PQ > D A N T E WWW: http://www.dante.net United Kingdom > > > > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200109041616.f84GGC898315>