Date: Fri, 4 Jun 2010 11:11:27 +0100 From: "Robert N. M. Watson" <rwatson@freebsd.org> To: =?iso-8859-1?Q?Ermal_Lu=E7i?= <eri@freebsd.org> Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org Subject: Re: svn commit: r208766 - stable/8/sys/netinet Message-ID: <0925CEED-A973-4820-A8DA-E5EDD44CCBDF@freebsd.org> In-Reply-To: <AANLkTimEyii8eF05vgQRuSh5eQVwBceIcxwgFeUSu80b@mail.gmail.com> References: <201006030855.o538tjke024438@svn.freebsd.org> <AANLkTimEyii8eF05vgQRuSh5eQVwBceIcxwgFeUSu80b@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3 Jun 2010, at 14:09, Ermal Lu=E7i wrote: > Would it make sense to remove even passing the interface name up and > actually send the > interface index? >=20 > That is what we are doing at pfSense and it works quite ok. I see one important argument for doing this: - Looking up an interface by number instead of by name has a number of = advantages. - User programs that already reason about network interfaces by ifindex = don't have to take an indirection. However, it has two important downsides: - It changes an existing API that a moderate number of applications = depend on. - Applications that reason about ifnet names now have to take an = indirection, which might well mean monitoring routing sockets for = interface renames/additions/removals, additional sysctls, etc. As such, I'm not sure the benefits of replacing the current behavior = with the proposed new behavior is worth the cost. An alternative = approach might be to add a socket option to set the disposition of the = divert socket, defaulting to current behavior but optionally switching = to a different interpretation of the sockaddr passed in (i.e., use the = ifindex instead when the option is set). Could you say a bit more about = why you found this change advantageous in your environment, and whether = the socket option approach would be problematic there? Robert=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0925CEED-A973-4820-A8DA-E5EDD44CCBDF>