Date: Sat, 14 Jan 2012 02:48:46 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Ermal Lu?i <eri@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r229850 - in head: etc/rc.d sys/contrib/pf/net sys/netinet Message-ID: <20120113224846.GR74141@FreeBSD.org> In-Reply-To: <CAPBZQG36GvQ9Tt31oh2PMjDcgmYGi0qpohex_Dds4AcU640WAw@mail.gmail.com> References: <201201090850.q098oNme031479@svn.freebsd.org> <CAPBZQG36GvQ9Tt31oh2PMjDcgmYGi0qpohex_Dds4AcU640WAw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jan 13, 2012 at 11:34:15PM +0100, Ermal Lu?i wrote: E> You ARE testing this right? Sure. E> Since you removed code that you do not actually mention at all in the E> commit message!!! What code are you worried about? E> On Mon, Jan 9, 2012 at 9:50 AM, Gleb Smirnoff <glebius@freebsd.org> wrote: E> E> > Author: glebius E> > Date: Mon Jan 9 08:50:22 2012 E> > New Revision: 229850 E> > URL: http://svn.freebsd.org/changeset/base/229850 E> > E> > Log: E> > Bunch of fixes to pfsync(4) module load/unload: E> > E> > o Make the pfsync.ko actually usable. Before this change loading it E> > didn't register protosw, so was a nop. However, a module /boot/kernel E> > did confused users. E> > o Rewrite the way we are joining multicast group: E> > - Move multicast initialization/destruction to separate functions. E> > - Don't allocate memory if we aren't going to join a multicast group. E> > - Use modern API for joining/leaving multicast group. E> > - Now the utterly wrong pfsync_ifdetach() isn't needed. E> > o Move module initialization from SYSINIT(9) to moduledata_t method. E> > o Refuse to unload module, unless asked forcibly. E> > o Improve a bit some FreeBSD porting code: E> > - Use separate malloc type. E> > - Simplify swi sheduling. E> > E> > This change is probably wrong from VIMAGE viewpoint, however pfsync E> > wasn't VIMAGE-correct before this change, too. E> > E> > Glanced at by: bz -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120113224846.GR74141>