Date: Sat, 29 Oct 2011 19:06:30 +0000 From: Andrej Zverev <az@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/162151: [PATCH] lang/perl5.12 fix two issue with BSDPAN Message-ID: <E1RKEEg-0006sR-R5@sunner.semmy.ru> Resent-Message-ID: <201110291510.p9TFA9VU031440@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 162151
>Category: ports
>Synopsis: [PATCH] lang/perl5.12 fix two issue with BSDPAN
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Oct 29 15:10:09 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Andrej Zverev
>Release: FreeBSD 8.2-STABLE amd64
>Organization:
>Environment:
System: FreeBSD sunner.semmy.ru 8.2-STABLE FreeBSD 8.2-STABLE #0: Sat Aug 6 10:31:24 UTC 2011 root@:/usr/obj/usr/src/sys/SUNNER amd64
>Description:
This patch fixes one error and one warning.
Change requied to bump portrevision for lang/perl5.10, lang/perl5.12, lang/perl5.14
after apply.
1) Fix warning:
Warning: prerequisite ExtUtils::MakeMaker x.xx not found. We have unknown version.
Now BSDPAN will inherit EX::MM version.
2) Fix incorrect directory processing:
BSDPAN Packlist.pm loops forever in get_dir_list while processing "..".
This will occurs when installing modules directly via cpan.
1: Reported by swills@FreeBSD.org, patched by tobez@FreeBSD.org
2: Reported by doubg@FreeBSD.org, pathed by az@FreeBSD.org
>How-To-Repeat:
>Fix:
--- patch-BSDPAN-5.12.1-1.diff begins here ---
diff -Nru BSDPAN-5.12.1_20100713.orig/ExtUtils/MakeMaker.pm BSDPAN-5.12.1_20100713/ExtUtils/MakeMaker.pm
--- BSDPAN-5.12.1_20100713.orig/ExtUtils/MakeMaker.pm 2010-04-22 16:49:02.000000000 +0000
+++ BSDPAN-5.12.1_20100713/ExtUtils/MakeMaker.pm 2011-10-29 18:50:52.868462011 +0000
@@ -17,6 +17,8 @@
use BSDPAN::Override;
use File::Basename;
+our $VERSION = $ExtUtils::MakeMaker::VERSION;
+
sub WriteMakefile
{
my $orig = shift;
diff -Nru BSDPAN-5.12.1_20100713.orig/ExtUtils/Packlist.pm BSDPAN-5.12.1_20100713/ExtUtils/Packlist.pm
--- BSDPAN-5.12.1_20100713.orig/ExtUtils/Packlist.pm 2010-07-13 15:59:07.000000000 +0000
+++ BSDPAN-5.12.1_20100713/ExtUtils/Packlist.pm 2011-10-28 13:55:55.061443875 +0000
@@ -214,6 +214,7 @@
while (-d $file) {
$file =~ s|/([^/]+)$||;
my $last = $1;
+ last if $file =~ /^\.\.?$/;
last if $last eq "bin";
last if $last eq "auto";
last if $last eq "man1";
--- patch-BSDPAN-5.12.1-1.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E1RKEEg-0006sR-R5>