Date: Tue, 14 Jan 1997 17:54:48 +1100 From: Bruce Evans <bde@zeta.org.au> To: bde@zeta.org.au, jkh@time.cdrom.com Cc: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-gnu@freefall.freebsd.org, jkh@freefall.freebsd.org Subject: Re: cvs commit: src/gnu/usr.bin/texinfo/install-info Makefile Message-ID: <199701140654.RAA27339@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>> Anywhere early is reasonable.
>
>I must respectfully disagree.
There are many precedents for it. The include and lib dirs are installed
first so that their headers can be perlified (this is broken for headers
installed from other directories).
>/usr/src/Makefile has two properties I
>don't want to screw up here, both of which would be casualties of this
>change:
>
> 1. The SUBDIR list is in alphabetical order, making it easy to
> find out if something has been omitted or not.
It's not in alphabetical order. Apart from include and lib, eBones,
secure, and lkm are out of order for no apparent reason, and etc,
local and ports are out of order for bootstrapping.
> 2. The subdirs listed are all top level dirs in /usr/src. If I
> were to add share/info to the list, it would get traversed
> *twice* - once at the beginning and once again during share
> (and your change doesn't respect NOSHARE, as the subsequent
> reference does).
Installing it twice takes 0.58 seconds for the first time and 0.28
seconds for the second time here :-). NOSHARE is almost useless, since
many man and info pages are installed in /usr/share. Installing the
dir file as well as the info pages won't hurt unless the source directory
is missing, and if it is missing then your change is equally broken:
@(cd /usr/src/share/info; make install)
This has several other bugs:
- absolute pathname for the directory. This is difficult to fix, since it
is hard to determine the root of the source tree, if any. (If it could
be found easily, then it would already be used to locate non-absolute
versions of *.mk.)
- `make' should be ${MAKE}.
>That's what I meant when I said that the proposed cure was worse than
>the disease. I don't want to needlessly obfuscate /usr/src/Makefile
I agree that your proposed cure is worse :-).
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199701140654.RAA27339>