Date: Wed, 09 Jun 2010 15:47:16 +0100 From: Gavin Atkinson <gavin@FreeBSD.org> To: Ulrich =?ISO-8859-1?Q?Sp=F6rlein?= <uqs@spoerlein.net> Cc: Matthew D Fleming <mdf@FreeBSD.org>, Doug Barton <dougb@FreeBSD.org>, cvs-doc@FreeBSD.org, cvs-all@FreeBSD.org, zml@FreeBSD.org, doc-committers@FreeBSD.org Subject: Re: cvs commit: doc/en_US.ISO8859-1/share/sgml authors.ent Message-ID: <1276094836.11123.258.camel@buffy.york.ac.uk> In-Reply-To: <20100609105300.GN39829@acme.spoerlein.net> References: <201006041730.o54HUlnc016635@repoman.freebsd.org> <4C093F30.6050103@FreeBSD.org> <20100609105300.GN39829@acme.spoerlein.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 2010-06-09 at 12:53 +0200, Ulrich Sp=F6rlein wrote: > On Fri, 04.06.2010 at 11:00:16 -0700, Doug Barton wrote: > > On 06/04/10 10:30, Matthew D Fleming wrote: > > > mdf 2010-06-04 17:30:47 UTC > > > > > > FreeBSD doc repository (src committer) > > > > > > Modified files: > > > en_US.ISO8859-1/share/sgml authors.ent > > > Log: > > > Add myself to the list of committers. > > > > > > Revision Changes Path > > > 1.509 +2 -0 doc/en_US.ISO8859-1/share/sgml/authors.ent > > > > > > http://www.FreeBSD.org/cgi/cvsweb.cgi/doc/en_US.ISO8859-1/share/sgml/= authors.ent.diff?&r1=3D1.508&r2=3D1.509&f=3Dh > >=20 > > Matthew, > >=20 > > Couple of things ... first, welcome to the fun! Second, (and your mento= r=20 > > really should be filling you in on this stuff) it's customary for=20 > > related commits in the same tree to go in together. So rather than=20 > > committing these doc updates one at a time it would have been better to= =20 > > get all the related stuff in one go. Also, until you're released from=20 > > mentorship ALL of your commits should indicate that they were approved=20 > > by your mentor (which implies of course that zml reviews them first). >=20 > The handbook is somewhat misleading in this regard, as it warns you that > the www build may break if stuff happens in the wrong order. People may > therefore opt to err on the side of caution by putting stuff in > sequentially. Indeed the handbook actually goes one step further than that: It (implicitly) suggests that these files should be committed to one at a time, as the steps jump from repo to repo and back: if you follow the instructions in order you end up committing to the doc repo, then www, then doc, www, doc, src, ports, and finally src. If it is now preferred that they should all be committed in one go then maybe the committers-guide should be updated. Gavin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1276094836.11123.258.camel>