Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 7 May 2014 16:45:06 +0000 (UTC)
From:      Jim Harris <jimharris@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-9@freebsd.org
Subject:   svn commit: r265562 - stable/9/sys/dev/nvme
Message-ID:  <201405071645.s47Gj606069912@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jimharris
Date: Wed May  7 16:45:05 2014
New Revision: 265562
URL: http://svnweb.freebsd.org/changeset/base/265562

Log:
  MFC r263277:
  
  nvme: Remove the software progress marker SET_FEATURE command during
  controller initialization.
  
  The spec says OS drivers should send this command after controller
  initialization completes successfully, but other NVMe OS drivers are
  not sending this command.  This change will therefore reduce differences
  between the FreeBSD and other OS drivers.

Modified:
  stable/9/sys/dev/nvme/nvme_ctrlr.c
Directory Properties:
  stable/9/sys/   (props changed)
  stable/9/sys/dev/   (props changed)

Modified: stable/9/sys/dev/nvme/nvme_ctrlr.c
==============================================================================
--- stable/9/sys/dev/nvme/nvme_ctrlr.c	Wed May  7 16:44:02 2014	(r265561)
+++ stable/9/sys/dev/nvme/nvme_ctrlr.c	Wed May  7 16:45:05 2014	(r265562)
@@ -842,16 +842,6 @@ nvme_ctrlr_start(void *ctrlr_arg)
 
 	for (i = 0; i < ctrlr->num_io_queues; i++)
 		nvme_io_qpair_enable(&ctrlr->ioq[i]);
-
-	/*
-	 * Clear software progress marker to 0, to indicate to pre-boot
-	 *  software that OS driver load was successful.
-	 *
-	 * Chatham does not support this feature.
-	 */
-	if (pci_get_devid(ctrlr->dev) != CHATHAM_PCI_ID)
-		nvme_ctrlr_cmd_set_feature(ctrlr,
-		    NVME_FEAT_SOFTWARE_PROGRESS_MARKER, 0, NULL, 0, NULL, NULL);
 }
 
 void



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201405071645.s47Gj606069912>