Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 7 May 2014 16:45:51 +0000 (UTC)
From:      Jim Harris <jimharris@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-9@freebsd.org
Subject:   svn commit: r265563 - stable/9/sys/dev/nvme
Message-ID:  <201405071645.s47GjpEU070043@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jimharris
Date: Wed May  7 16:45:50 2014
New Revision: 265563
URL: http://svnweb.freebsd.org/changeset/base/265563

Log:
  MFC r263278:
  
  nvme:  NVMe specification dictates 4-byte alignment for PRPs (not 8).

Modified:
  stable/9/sys/dev/nvme/nvme_qpair.c
Directory Properties:
  stable/9/sys/   (props changed)
  stable/9/sys/dev/   (props changed)

Modified: stable/9/sys/dev/nvme/nvme_qpair.c
==============================================================================
--- stable/9/sys/dev/nvme/nvme_qpair.c	Wed May  7 16:45:05 2014	(r265562)
+++ stable/9/sys/dev/nvme/nvme_qpair.c	Wed May  7 16:45:50 2014	(r265563)
@@ -498,8 +498,9 @@ nvme_qpair_construct(struct nvme_qpair *
 
 	mtx_init(&qpair->lock, "nvme qpair lock", NULL, MTX_DEF);
 
+	/* Note: NVMe PRP format is restricted to 4-byte alignment. */
 	bus_dma_tag_create(bus_get_dma_tag(ctrlr->dev),
-	    sizeof(uint64_t), PAGE_SIZE, BUS_SPACE_MAXADDR,
+	    4, PAGE_SIZE, BUS_SPACE_MAXADDR,
 	    BUS_SPACE_MAXADDR, NULL, NULL, NVME_MAX_XFER_SIZE,
 	    (NVME_MAX_XFER_SIZE/PAGE_SIZE)+1, PAGE_SIZE, 0,
 	    NULL, NULL, &qpair->dma_tag);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201405071645.s47GjpEU070043>