Date: Thu, 20 Aug 1998 00:30:00 -0700 (PDT) From: Mike Smith <mike@smith.net.au> To: freebsd-bugs@FreeBSD.ORG Subject: Re: kern/7144: WaveLAN interface moves packets to uper layer while dst addr does not belong to that interface (even while not in allmulti/promisc mode) Message-ID: <199808200730.AAA01561@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/7144; it has been noted by GNATS.
From: Mike Smith <mike@smith.net.au>
To: Max Gotlib <max@cca.usart.ru>
Cc: Greg Troxel <gdt@ir.bbn.com>, freebsd-gnats-submit@freebsd.org,
Jim Binkley <jrb@cs.pdx.edu>, Mike Smith <mike@smith.net.au>
Subject: Re: kern/7144: WaveLAN interface moves packets to uper layer while dst addr does not belong to that interface (even while not in allmulti/promisc mode)
Date: Thu, 20 Aug 1998 00:18:06 +0000
Please make sure you copy me on the results of this; if it works OK
then I'll commit it (but otherwise I am going to forget). Please also
mention the PR number when you do.
Thanks.
> Hi!
>
> Glad too see that wavelan technology is of a particular interest ...
> And as for suggested patch - totally agreed :)))
>
> And one Q. more - I sent another patch (kern/7044) that fixed
> (at least for me) wavelan board initialization process...
> Can you test it on your board, please, and if the results
> will be successfull - i would be glad to see it (or it's variant)
> in the FreeBSD source tree...
>
> With best regards,
> Max.
>
> On Wed, 19 Aug 1998, Greg Troxel wrote:
>
> > I had just about the same problem, with 915 MHz ISA wavelans cards and
> > no wavepoints. Running mrouted, which set IFF_ALLMULTI caused unicast
> > packets with a mac address not matching the local machine to be
> > forwarded. My fix is different, and I believe makes bpf work
> > correctly.
> >
> > The check for dropping unicast packets not sent to our ethernet
> > address is after the bpf tap, but not conditioned on it. All packets
> > received should get handed to bpf, and unicast packets not to us (mac)
> > should get dropped whether or not there is a bpf listener. I believe
> > that the common optimization that the interface is in hw promisc mode
> > iff there is a bpf listener is in general wrong, but more frequently
> > so on wavelans.
> >
> > I think Max's fix makes bpf listeners not see unicast packets sent to
> > others, but I'm not sure.
> >
> > One can argue that checking on MOD_ENAL is wrong, but the code only
> > drops packets that shouldn't be received. The correctness condition
> > is that it be run whenever unicast packets without our mac address can
> > be received.
>
>
--
\\ Sometimes you're ahead, \\ Mike Smith
\\ sometimes you're behind. \\ mike@smith.net.au
\\ The race is long, and in the \\ msmith@freebsd.org
\\ end it's only with yourself. \\ msmith@cdrom.com
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199808200730.AAA01561>