Date: Thu, 14 May 2015 10:00:32 -0600 From: Adam Weinberger <adamw@adamw.org> To: "Philip M. Gollucci" <pgollucci@p6m7g8.com> Cc: Bryan Drewery <bdrewery@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org> Subject: Re: svn commit: r386285 - head/security/keychain Message-ID: <082DB80D-6385-4F4F-8A86-2DB4561E39E8@adamw.org> In-Reply-To: <CACM2dAaFL6F-=mbfODTRrR83L%2BGeLfxzcM16DoroP1shmP6NHQ@mail.gmail.com> References: <201505140101.t4E11r9T031351@svn.freebsd.org> <08F806A7-3CD9-417A-BA4E-AF739E83B6A8@adamw.org> <CACM2dAaFL6F-=mbfODTRrR83L%2BGeLfxzcM16DoroP1shmP6NHQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 13 May, 2015, at 21:20, Philip M. Gollucci <pgollucci@p6m7g8.com> = wrote: >=20 > Then it needs an option not an if exists() Bryan, can you please consider reverting it, or giving me approval to = revert it? It may fix the case when the port is built in poudriere = without sshd in base, but it is a regression for everybody else. # Adam --=20 Adam Weinberger adamw@adamw.org http://www.adamw.org >=20 > On Wed, May 13, 2015 at 10:37 PM, Adam Weinberger <adamw@adamw.org> = wrote: > > On 13 May, 2015, at 19:01, Bryan Drewery <bdrewery@FreeBSD.org> = wrote: > > > > Author: bdrewery > > Date: Thu May 14 01:01:52 2015 > > New Revision: 386285 > > URL: https://svnweb.freebsd.org/changeset/ports/386285 > > > > Log: > > Don't use exists() for the ssh dependency. The RUN_DEPENDS line = already > > handles checking if these files exist. Removing this fixes = poudriere > > already rebuilding this port when there is no base sshd and only a = port > > version. >=20 > Now keychain unconditionally brings in openssh-portable, which it = didn't before. >=20 > # Adam >=20 >=20 > -- > Adam Weinberger > adamw@adamw.org > http://www.adamw.org >=20 >=20 >=20 >=20 >=20 > --=20 > = --------------------------------------------------------------------------= ------- > Curb: Your ride is here > 4096R/D21D2752 ECDF B597 B54B 7F92 753E E0EA F699 A450 D21D 2752 > Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354 > Member, Apache Software Foundation > Committer, FreeBSD Foundation > Consultant, P6M7G8 Inc. > Sr. Director IT Operations, Curb >=20 > What doesn't kill us can only make us stronger; > Except it almost kills you.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?082DB80D-6385-4F4F-8A86-2DB4561E39E8>