Date: Thu, 31 Dec 2015 02:08:54 +0100 From: Oliver Pinter <oliver.pinter@hardenedbsd.org> To: Mateusz Guzik <mjg@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r292440 - in head/sys: kern sys Message-ID: <CAPQ4ffsSsdFDS79R7GOdK2nhCAXQ0x3WmXq%2BsQ%2Bjtqy0u0ywhg@mail.gmail.com> In-Reply-To: <201512181633.tBIGXFff046683@repo.freebsd.org> References: <201512181633.tBIGXFff046683@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/18/15, Mateusz Guzik <mjg@freebsd.org> wrote: > Author: mjg > Date: Fri Dec 18 16:33:15 2015 > New Revision: 292440 > URL: https://svnweb.freebsd.org/changeset/base/292440 > > Log: > proc: fix a race which could result in dereference of bad p_pgrp pointer > on fork > > During fork p_starcopy - p_endcopy area of a process is populated with > bcopy > with only proc lock held. Another forking thread can find such a process > and > proceed to access p_pgrp included in said area. > > Fix the problem by moving the field outside. It is being properly > assigned > later. > > Reviewed by: kib > Diagnosed by: kib > Tested by: Fabian Keil <freebsd-listen fabiankeil.de> > MFC after: 10 days Hi mjg@! Just an MFC reminder and question: This patch is still needs on 10-STABLE? > > Modified: > head/sys/kern/kern_proc.c > head/sys/sys/proc.h > > Modified: head/sys/kern/kern_proc.c >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPQ4ffsSsdFDS79R7GOdK2nhCAXQ0x3WmXq%2BsQ%2Bjtqy0u0ywhg>