Date: Sat, 19 Oct 1996 19:11:35 +0900 From: hosokawa@mt.cs.keio.ac.jp (HOSOKAWA Tatsumi) To: bugs@freebsd.org Cc: hosokawa@mt.cs.keio.ac.jp Subject: type of dk_flags (wd.c) should be longer Message-ID: <199610191011.TAA04109@frig.mt.cs.keio.ac.jp>
next in thread | raw e-mail | index | archive | help
In sys/i386/isa/wd.c:
short dk_flags; /* drive characteristics found */
#define DKFL_SINGLE 0x00004 /* sector at a time mode */
#define DKFL_ERROR 0x00008 /* processing a disk error */
#define DKFL_LABELLING 0x00080 /* readdisklabel() in progress */
#define DKFL_32BIT 0x00100 /* use 32-bit i/o mode */
#define DKFL_MULTI 0x00200 /* use multi-i/o mode */
#define DKFL_BADSCAN 0x00400 /* report all errors */
It seems bit operation to dk_flags results in invalid behavior. I
think that the type of dk_flags should be longer (ex. long).
--
HOSOKAWA, Tatsumi E-mail: hosokawa@mt.cs.keio.ac.jp
WWW homepage: http://www.mt.cs.keio.ac.jp/person/hosokawa.html
Department of Computer Science, Keio University, Yokohama, Japan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199610191011.TAA04109>