Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 3 May 2016 20:34:28 -0700
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        Garrett Cooper <ngie@FreeBSD.org>, src-committers@freebsd.org, svn-src-user@freebsd.org
Subject:   Re: svn commit: r299037 - in user/ngie/release-pkg-fix-tests/cddl/usr.sbin/dtrace/tests: . tools
Message-ID:  <57296DC4.5030309@FreeBSD.org>
In-Reply-To: <201605040216.u442GDkd081814@repo.freebsd.org>
References:  <201605040216.u442GDkd081814@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 5/3/16 7:16 PM, Garrett Cooper wrote:
> Author: ngie
> Date: Wed May  4 02:16:13 2016
> New Revision: 299037
> URL: https://svnweb.freebsd.org/changeset/base/299037
> 
> Log:
>   Use ${PACKAGE}FILES instead of TESTFILES
>   
>   For some odd reason make was getting "lost" with the former idiom and wasn't
>   installing .d and .ksh scripts..
> 
...
> 
> Modified: user/ngie/release-pkg-fix-tests/cddl/usr.sbin/dtrace/tests/tools/genmakefiles.sh
> ==============================================================================
> --- user/ngie/release-pkg-fix-tests/cddl/usr.sbin/dtrace/tests/tools/genmakefiles.sh	Wed May  4 02:11:45 2016	(r299036)
> +++ user/ngie/release-pkg-fix-tests/cddl/usr.sbin/dtrace/tests/tools/genmakefiles.sh	Wed May  4 02:16:13 2016	(r299037)
> @@ -52,7 +52,9 @@ WITH_CTF=YES
>  # This Makefile was generated by \$srcdir${ORIGINDIR#${TOPDIR}}/genmakefiles.sh.
>  #
>  
> -TESTFILES= \\
> +PACKAGE=	tests
> +
> +\${PACKAGE}FILES= \\
>  $tfiles
>  
>  TESTEXES= \\
> 

Presumably because a. PACKAGE is lowercase 'tests' so you get testsFILES
and is b. is plural here rather than singular such as TESTFILES was.

-- 
Regards,
Bryan Drewery



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?57296DC4.5030309>