Date: Fri, 15 May 2015 00:07:40 +0800 From: Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org> To: Bryan Drewery <bdrewery@freebsd.org> Cc: Adam Weinberger <adamw@adamw.org>, "Philip M. Gollucci" <pgollucci@p6m7g8.com>, "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r386285 - head/security/keychain Message-ID: <CAMHz58SQkrjmhfx2O7EJNu5d9YvjShvYL57bwpzgSSWOGLLz9g@mail.gmail.com> In-Reply-To: <5554C761.3060609@FreeBSD.org> References: <201505140101.t4E11r9T031351@svn.freebsd.org> <08F806A7-3CD9-417A-BA4E-AF739E83B6A8@adamw.org> <CACM2dAaFL6F-=mbfODTRrR83L%2BGeLfxzcM16DoroP1shmP6NHQ@mail.gmail.com> <082DB80D-6385-4F4F-8A86-2DB4561E39E8@adamw.org> <5554C761.3060609@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, May 15, 2015 at 12:03 AM, Bryan Drewery <bdrewery@freebsd.org>
wrote:
> On 5/14/2015 11:00 AM, Adam Weinberger wrote:
> >> On 13 May, 2015, at 21:20, Philip M. Gollucci <pgollucci@p6m7g8.com>
> wrote:
> >>
> >> Then it needs an option not an if exists()
> >
> > Bryan, can you please consider reverting it, or giving me approval to
> revert it? It may fix the case when the port is built in poudriere without
> sshd in base, but it is a regression for everybody else.
> >
> > # Adam
> >
> >
>
> No. The way RUN_DEPENDS is supposed to work is what I said in the
> commit. These exists() checks are redundant and confuse the package
> dependencies.
>
> How are you building? It's possible the tool you are using is
> incorrectly handling RUN_DEPENDS.
>
> --
> Regards,
> Bryan Drewery
>
>
I could confirm that keychain 2.8.0_2 will not bring in openssh-portable if
you have ssh-agent in base.
But 'make run-depends-list' will give you incorrect result.
Regards,
sunpoet
% make install
===> Installing for keychain-2.8.0_2
===> keychain-2.8.0_2 depends on file: /usr/local/bin/bash - found
===> keychain-2.8.0_2 depends on executable: ssh-agent - found
===> Checking if keychain already installed
actual-package-depends: dependency on /usr/bin/ssh-agent not registered
(normal if it belongs to base)
===> Registering installation for keychain-2.8.0_2
Installing keychain-2.8.0_2...
% pkg info -dx keychain
keychain-2.8.0_2:
bash-4.3.33
% make run-depends-list
/usr/ports/security/openssh-portable
/usr/ports/shells/bash
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58SQkrjmhfx2O7EJNu5d9YvjShvYL57bwpzgSSWOGLLz9g>