Date: Tue, 24 Jul 2001 17:04:53 -0700 (PDT) From: Julian Elischer <julian@elischer.org> To: Brooks Davis <brooks@one-eyed-alien.net> Cc: net@freebsd.org, hackers@freebsd.org Subject: Re: review request: ng_split cleanup Message-ID: <Pine.BSF.4.21.0107241659100.20936-100000@InterJet.elischer.org> In-Reply-To: <20010724143734.A1412@Odin.AC.HMC.Edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 24 Jul 2001, Brooks Davis wrote: > Please review the following diff for the ng_split netgraph node. It > cleans up a number of style issues, removes some functions that just did > that the default functions did, and renames the node to split from > ng_split to follow the normal convention. In addition to this diff, I > plan to commit a Makefile update to make this part of the modules build > and a sys/conf/options entry to allow static compilation. > > Thanks, > Brooks > > Index: ng_split.c > =================================================================== > RCS file: /home/ncvs/src/sys/netgraph/ng_split.c,v > retrieving revision 1.1 [...] > diff -u -r1.1 ng_split.c > - /* > - * XXX Really here we should just remove metadata we understand. > - */ > - NGI_GET_META(item, meta); > - NG_FREE_META(meta); this one is tricky.. it was written as part of a set of nodes that pass around their own metadata. The original idea was (so the author suggested) to stop those metadata structures from propogating out of the limited part of the graph that knew about them. However I don't see any harm in letting them go, since any node that doesn't understand a particular metadata type should ignore it.. otherwise your patch seems functionally the same.. please feel free to commit. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0107241659100.20936-100000>