Skip site navigation (1)Skip section navigation (2) 
Date:      Tue, 8 Oct 2013 19:12:47 -0400
From:      Glen Barber <gjb@FreeBSD.org>
To:        Jim Harris <jimharris@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r256151 - in head/sys/dev: nvd nvme
Message-ID:  <20131008231247.GA5745@glenbarber.us>
In-Reply-To: <201310081544.r98Fi4R8096543@svn.freebsd.org>
References:  <201310081544.r98Fi4R8096543@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help 

--BXVAT5kNtrzKuDFl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Oct 08, 2013 at 03:44:04PM +0000, Jim Harris wrote:
> Author: jimharris
> Date: Tue Oct  8 15:44:04 2013
> New Revision: 256151
> URL: http://svnweb.freebsd.org/changeset/base/256151
>=20
> Log:
>   Add driver-assisted striping for upcoming Intel NVMe controllers that c=
an
>   benefit from it.
>  =20

> Modified: head/sys/dev/nvme/nvme_ns.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/sys/dev/nvme/nvme_ns.c	Tue Oct  8 14:10:32 2013	(r256150)
> +++ head/sys/dev/nvme/nvme_ns.c	Tue Oct  8 15:44:04 2013	(r256151)
> @@ -34,13 +34,31 @@ __FBSDID("$FreeBSD$");
>  #include <sys/disk.h>
>  #include <sys/fcntl.h>
>  #include <sys/ioccom.h>
> +#include <sys/malloc.h>
>  #include <sys/module.h>
>  #include <sys/proc.h>
> =20
>  #include <dev/pci/pcivar.h>
> =20
> +#include <geom/geom.h>
> +
>  #include "nvme_private.h"
> =20

I think an include is missing.  This breaks the LINT build.

cc  -c -O2 -pipe -fno-strict-aliasing  -std=3Dc99  -Wall -Wredundant-decls
-Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes
-Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign
-fformat-extensions  -Wmissing-include-dirs -fdiagnostics-show-option
-Wno-error-tautological-compare -Wno-error-empty-body
-Wno-error-parentheses-equality  -nostdinc  -I. -I/src/sys
-I/src/sys/contrib/altq -I/src/sys/contrib/libfdt -D_KERNEL
-DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -DGPROF -DGPROF4
-DGUPROF -fno-builtin -fno-omit-frame-pointer
-mno-omit-leaf-frame-pointer -mno-aes -mno-avx -mcmodel=3Dkernel
-mno-red-zone -mno-mmx -mno-sse -msoft-float
-fno-asynchronous-unwind-tables -ffreestanding -fstack-protector -Werror
-pg /src/sys/dev/nvme/nvme_ns.c
In file included from /src/sys/dev/nvme/nvme_ns.c:43:
/src/sys/geom/geom.h:356:3: error: implicit declaration of function
'KASSERT' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                KASSERT(g_valid_obj(ptr) =3D=3D 0,
                ^
/src/sys/geom/geom.h:357:8: error: expression result unused
[-Werror,-Wunused-value]
                    ("g_free(%p) of live object, type %d", ptr,
                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/src/sys/geom/geom.h:357:46: error: expression result unused
[-Werror,-Wunused-value]
                    ("g_free(%p) of live object, type %d", ptr,
                                                           ^~~
3 errors generated.
*** Error code 1

http://tinderbox.freebsd.org/tinderbox-head-build-HEAD-amd64-amd64.full

Glen


--BXVAT5kNtrzKuDFl
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (FreeBSD)

iQIcBAEBCAAGBQJSVJFvAAoJELls3eqvi17QEOsP/2pJ4EYdBapH9eBoKHf89MBC
5mehp2woHgD8dCcuFVKpMne53qylTtY1NGlQBoDB9nu46DKJSyN2k09G09aEXuIY
+gHMuLvDG/f6+cZNRz5Gd5muvQkkrJPiTYl8i378JZ3aseM014p0bSpgWQOxDkc/
KVN9T0Wp2HnELwvbHKBR5haMokyBh+SO4+ReJsjJ0CKv6I7jlopAoEyu1FnSXp8g
29Hgnq9VDj4TTO3eK9Lgju/9mJtu7J/r1Fhpgvp9lpF7a+NCJN4QaI5H/0cleyqx
2XWpPiYlxKNlnNsaSBbiUw2rhmxPAZMLbi4aoh0MP6WqD6s7x/1K/Hdg+R4XCs/C
KBK3d11gcPH0P9YQb8P8Ph9/kt0xeLy1bEfRTkiOOPL5TQEqIhbtfqHAZCI6wFwf
nIaA60Ooafu8tIZ27KgYXnc8Re2jrHpD1miipbzIBoUh21+N6qHKn3aM+alvCqJH
dlaq/Qbb8fPyRZczsr9FQSLbYfAxKSkMOgXBMK1kv32K2+Bwx+tpab94vLJ175a0
6Wlbj/X6ciH1KXvftBbJrKyqJ1cKB+EA5Kbd6IiKceVg58HFGENO3O9i69BuIB+K
SXT2oE5nv7YMQJUziG7YkPWzn6WdOG6K1Rnnm5jMyGd8ecm1ZmcckvBaJ10Mgx/8
iStlITzbt8kR600ARGAj
=lpGw
-----END PGP SIGNATURE-----

--BXVAT5kNtrzKuDFl--

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131008231247.GA5745>