Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 24 Apr 1996 21:27:21 +0930 (CST)
From:      Michael Smith <msmith@atrad.adelaide.edu.au>
To:        jmacd@CS.Berkeley.EDU (Josh MacDonald)
Cc:        bde@zeta.org.au, freebsd-hackers@FreeBSD.org
Subject:   Re: GNU binutils port
Message-ID:  <199604241157.VAA19097@genesis.atrad.adelaide.edu.au>
In-Reply-To: <199604240837.BAA19783@paris.CS.Berkeley.EDU> from "Josh MacDonald" at Apr 24, 96 01:37:57 am

next in thread | previous in thread | raw e-mail | index | archive | help
Josh MacDonald stands accused of saying:
> Oh dear....   I can't beleive you're saying this, "They are only warnings".
> 
> To me, it has, "My code sucks and I don't care." written all over
> it if you don't fix things so that they compile with no warnings
> and -Wall.  Perhaps kernel code is a bit different, but with 4700
> warnings, I'd be little scared.

gcc -Wall is _pedantic_.  Consider how many of the above are 
"Consider parentheses around assignment used as truth value", or
"Integer used as pointer without a cast" (for use of '0' as a [legitimate]
substitute for NULL.

A pile more would be historic warts where unions were avoided and pointers
to structures were passed around in a known context.

> > Bruce

-- 
]] Mike Smith, Software Engineer        msmith@atrad.adelaide.edu.au    [[
]] Genesis Software                     genesis@atrad.adelaide.edu.au   [[
]] High-speed data acquisition and      (GSM mobile) 0411-222-496       [[
]] realtime instrument control          (ph/fax)  +61-8-267-3039        [[
]] Collector of old Unix hardware.      "Where are your PEZ?" The Tick  [[



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199604241157.VAA19097>