Date: Mon, 20 Nov 2000 14:26:38 -0800 (PST) From: John Baldwin <jhb@FreeBSD.org> To: Alfred Perlstein <bright@wintelcom.net> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Doug Rabson <dfr@FreeBSD.org> Subject: Re: cvs commit: src/sys/alpha/alpha clock.c db_interface.c inter Message-ID: <XFMail.001120142638.jhb@FreeBSD.org> In-Reply-To: <20001119124403.M18037@fw.wintelcom.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 19-Nov-00 Alfred Perlstein wrote: > * Doug Rabson <dfr@FreeBSD.org> [001119 04:29] wrote: >> dfr 2000/11/19 04:28:42 PST >> >> Modified files: >> sys/alpha/alpha clock.c db_interface.c interrupt.c >> mp_machdep.c prom.c vm_machdep.c >> Log: >> Convert various calls to splhigh() to disable_intr() since splhigh() is >> now a no-op. > > Afaik the concensus was that spl's were not to be removed even > though they are no-ops. More like that spl's shouldnt' be removed until they are replaced by locks or something else. There are actually several spl's lying around sched_lock that should probably be axed as they serve to simply clutter the code. > You should probably put them back. Perhaps if they are to be replaced with a lock later on. -- John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.001120142638.jhb>