Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 18 Jan 2006 01:10:17 GMT
From:      Warner Losh <imp@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 89879 for review
Message-ID:  <200601180110.k0I1AHJU095154@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=89879

Change 89879 by imp@imp_Speedy on 2006/01/18 01:09:47

	Don't destroy the lock on success.

Affected files ...

.. //depot/projects/arm/src/sys/arm/at91/if_ate.c#21 edit

Differences ...

==== //depot/projects/arm/src/sys/arm/at91/if_ate.c#21 (text+ko) ====

@@ -209,9 +209,10 @@
 	 */
 	err = bus_setup_intr(dev, sc->irq_res, INTR_TYPE_NET | INTR_MPSAFE,
 	    ate_intr, sc, &sc->intrhand);
-	if (err)
+	if (err) {
 		ether_ifdetach(ifp);
-	ATE_LOCK_DESTROY(sc);
+		ATE_LOCK_DESTROY(sc);
+	}
 out:;
 	if (err)
 		ate_deactivate(dev);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200601180110.k0I1AHJU095154>