Date: Sun, 13 Apr 2008 14:44:24 -0700 From: Xin LI <delphij@delphij.net> To: Christian Weisgerber <naddy@FreeBSD.ORG> Cc: cvs-ports@FreeBSD.ORG, d@delphij.net, cvs-all@FreeBSD.ORG, ports-committers@FreeBSD.ORG Subject: Re: cvs commit: ports/misc/findutils Makefile Message-ID: <48027EB8.4020105@delphij.net> In-Reply-To: <20080413190643.GA31023@kemoauc.mips.inka.de> References: <200804121532.m3CFW1kh078688@repoman.freebsd.org> <4801BE6A.9090902@delphij.net> <20080413190643.GA31023@kemoauc.mips.inka.de>
next in thread | previous in thread | raw e-mail | index | archive | help
Christian Weisgerber wrote: > Xin LI: > >>> Work around the assumption that openat() implies the existence of >>> fdopendir(). FreeBSD 8 has the former, but not the latter. >> What about just implementing it instead? I have a hackish patch for this. > > Maybe, but this is outside the purview of ports. > I also think the merits of having fdopendir(3) should be judged > independently of the latest GNU breakage. Yes I agree. I'll ask review for my patch before committing it against -HEAD. What I feel a bit concern is that if we force configure script not to use openat() we may lose the chance that these functions get exercised which will not be good Perhaps something like BROKEN would be better because they will be checked later, but that's only my $0.02 :) Cheers, -- Xin LI <delphij@delphij.net> http://www.delphij.net/ FreeBSD - The Power to Serve!
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?48027EB8.4020105>