Date: Mon, 25 Feb 2002 10:45:32 +0200 From: Maxim Sobolev <sobomax@FreeBSD.org> To: obrien@FreeBSD.org Cc: gnome@FreeBSD.org Subject: Re: bsd.gnome.mk needs this patch Message-ID: <3C79F9AC.C9A5088@FreeBSD.org> References: <20020224222548.A66147@dragon.nuxi.com> <3C79F2DA.69EAE6A0@FreeBSD.org> <20020225002521.B29201@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
David O'Brien wrote: > > On Mon, Feb 25, 2002 at 10:16:26AM +0200, Maxim Sobolev wrote: > > > Please commit ASAP. USE_MOTIF sets USE_XLIB, which then ensures the X11 > > > libs are installed. GTK(GNOME) should do the same. > > > > > > Index: bsd.gnome.mk > > > =================================================================== > > > RCS file: /home/ncvs/ports/Mk/bsd.gnome.mk,v > > > retrieving revision 1.13 > > > diff -u -r1.13 bsd.gnome.mk > > > --- bsd.gnome.mk 13 Jan 2002 12:05:07 -0000 1.13 > > > +++ bsd.gnome.mk 25 Feb 2002 06:24:39 -0000 > > > @@ -220,6 +220,7 @@ > > > .endif > > > .if defined(USE_GTK) > > > USE_GLIB= yes > > > +USE_XLIB= yes > > > .endif > > > > > > .if defined(USE_ESOUND) > > > > No, because X11 dependency inherited along with gtk+ dependency. > > To follow up, does this patch hurt anything?? Yes it doesn't, but it's pointless to insert nops here and there. > It helps solve a problem. Since you aren't the only one at gnome@, I'd > like to hear the other's opinions. Which problem? I do not see any real problem yet. Set USE_GTK in your port and do `make package-depends' - you'll see that X11 is there even without your patch. -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-gnome" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3C79F9AC.C9A5088>