Date: Thu, 26 Dec 2013 23:48:13 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: marino@freebsd.org Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Eitan Adler <eadler@freebsd.org>, ports-committers@freebsd.org Subject: Re: svn commit: r337624 - head/games/daimonin-music Message-ID: <20131226224813.GW40122@ithaqua.etoilebsd.net> In-Reply-To: <52BCB084.3040504@marino.st> References: <201312262215.rBQMF1ZF002032@svn.freebsd.org> <20131226223743.GV40122@ithaqua.etoilebsd.net> <52BCB084.3040504@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
--sL7C0a98p/u5aVah Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 26, 2013 at 11:41:08PM +0100, John Marino wrote: > On 12/26/2013 23:37, Baptiste Daroussin wrote: > > On Thu, Dec 26, 2013 at 10:15:01PM +0000, John Marino wrote: > >> Author: marino > >> Date: Thu Dec 26 22:15:01 2013 > >> New Revision: 337624 > >> URL: http://svnweb.freebsd.org/changeset/ports/337624 > >> > > The port itself is still wrong, NO_CHECKSUM is still being used, while > > bsd.port.mk specifically says it is not to be used inside a port, so th= is should > > either be fixed or the port should remain broken. > >=20 >=20 > I saw later this PR: http://www.freebsd.org/cgi/query-pr.cgi?pr=3D170052 >=20 > It is taken by eadler@. The patch itself is no longer good but at least > there was some attempt to fix it. I did not know NO_CHECKSUM was > internal use only. It built fine in poudriere, which is where I tested > it. Is eadler going to follow up? or at least release the PR? >=20 > John eadler is afk for a moment, just take the pr ;) if he complains tell him that s my fault Bapt --sL7C0a98p/u5aVah Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iEYEARECAAYFAlK8si0ACgkQ8kTtMUmk6ExCaACeOG1TbjpwN7X0SyP0gSqfy8h2 4lgAoKWh4N0+CZg+NYdZG8zTl+usNTBG =cOYE -----END PGP SIGNATURE----- --sL7C0a98p/u5aVah--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131226224813.GW40122>