Date: Tue, 2 Apr 1996 11:10:32 -0500 From: Garrett Wollman <wollman@lcs.mit.edu> To: "Gary Palmer" <gpalmer@FreeBSD.ORG> Cc: FreeBSD-Current <FreeBSD-Current@FreeBSD.ORG> Subject: Linker sets & structures for networking code Message-ID: <9604021610.AA04475@halloran-eldar.lcs.mit.edu> In-Reply-To: <3278.828405118@palmer.demon.co.uk> References: <3278.828405118@palmer.demon.co.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
<<On Tue, 02 Apr 1996 01:31:58 +0100, "Gary Palmer" <gpalmer@FreeBSD.ORG> said: > There seems to be something fundamentally WRONG in some of the > networking stuff which I'm not sure how to fix. (I'm going through > LINT trying to fix as many warnings as I can). > People have noticed warnings like: > ../../kern/uipc_proto.c:62: warning: initialization from incompatible pointer type > (the error comes from the `raw_input' initialiser); > /sys/sys/protosw.h defines the input field to be: > void (*pr_input) __P((struct mbuf *, int len)); Every protocol family uses a different convention for calling its input functions. This was not a problem before the age of prototypes; now it is. It has never been clear to me why the lower-layer input functions are listed in the protosw[]s at all, since there is no way that they could sensibly ever get called through protocol processing. (I say ``sensibly'' since it is possible to do something really stupid which would do this; hopefully the added warnings will discourage anyone from attempting it.) > as `0', I can't see how raw_input ever gets call via the localsw > array. It never does; it wouldn't make any sense to do so. -GAWollman -- Garrett A. Wollman | Shashish is simple, it's discreet, it's brief. ... wollman@lcs.mit.edu | Shashish is the bonding of hearts in spite of distance. Opinions not those of| It is a bond more powerful than absence. We like people MIT, LCS, ANA, or NSA| who like Shashish. - Claude McKenzie + Florent Vollant
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9604021610.AA04475>