Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 23 Jul 2003 12:05:00 -0700 (PDT)
From:      Sam Leffler <sam@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 34890 for review
Message-ID:  <200307231905.h6NJ50AM020952@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=34890

Change 34890 by sam@sam_ebb on 2003/07/23 12:04:21

	mark MPSAFE

Affected files ...

.. //depot/projects/netperf/sys/dev/fxp/if_fxp.c#2 edit

Differences ...

==== //depot/projects/netperf/sys/dev/fxp/if_fxp.c#2 (text+ko) ====

@@ -811,11 +811,8 @@
 
 	/* 
 	 * Hook our interrupt after all initialization is complete.
-	 * XXX This driver has been tested with the INTR_MPSAFFE flag set
-	 * however, ifp and its functions are not fully locked so MPSAFE
-	 * should not be used unless you can handle potential data loss.
 	 */
-	error = bus_setup_intr(dev, sc->irq, INTR_TYPE_NET /*|INTR_MPSAFE*/,
+	error = bus_setup_intr(dev, sc->irq, INTR_TYPE_NET | INTR_MPSAFE,
 			       fxp_intr, sc, &sc->ih);
 	if (error) {
 		device_printf(dev, "could not setup irq\n");



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200307231905.h6NJ50AM020952>