Date: Fri, 19 Jun 2009 01:08:29 +0400 (MSD) From: Dmitry Morozovsky <marck@rinet.ru> To: =?ISO-8859-15?Q?Dag-Erling_Sm=F8rgrav?= <des@des.no> Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-7@freebsd.org, John Baldwin <jhb@freebsd.org> Subject: Re: svn commit: r194377 - stable/7/sys/dev/ath/ath_hal Message-ID: <alpine.BSF.2.00.0906190106430.87566@woozle.rinet.ru> In-Reply-To: <86eith5k7h.fsf@ds4.des.no> References: <200906171731.n5HHVktG082752@svn.freebsd.org> <alpine.BSF.2.00.0906181414270.40949@woozle.rinet.ru> <86iqit5sms.fsf@ds4.des.no> <200906181455.26797.jhb@freebsd.org> <86eith5k7h.fsf@ds4.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 18 Jun 2009, Dag-Erling Sm?rgrav wrote: DS> > I think Dmitry means more that all the prop changes stuff clutters the actual DS> > commit messages. I would like to see them removed from the subject line at DS> > least so that the subject line clearly shows where real changes are being DS> > made. DS> DS> That's reasonable - but I would still very much like to see prop changes DS> in the commit email. It's not just svn:mergeinfo, there have also been DS> cases of incorrect svn:keywords, and even someone who set svn:mime-type DS> to application/octet-stream on a couple of files because they couldn't DS> figure out the correct svn:keywords syntax. DS> DS> BTW, if you do as Dmitry suggests, how will you handle props-only DS> commits like r192599, r192646 or r192653? As for last question: there are _only_ props changes lines in the changes list. This can be treated as a stop-case for changing subject at all (also, these cases are rather rare comparing to normal development/merging) -- Sincerely, D.Marck [DM5020, MCK-RIPE, DM3-RIPN] [ FreeBSD committer: marck@FreeBSD.org ] ------------------------------------------------------------------------ *** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck@rinet.ru *** ------------------------------------------------------------------------
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.0906190106430.87566>