Date: Sun, 23 Mar 2008 11:30:03 GMT From: "Rong-en Fan" <grafan@gmail.com> To: perl@FreeBSD.org Subject: Re: ports/121992: [PATCH] archivers/p5-Compress-LZW: CPAN Macro Message-ID: <200803231130.m2NBU3VE049732@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/121992; it has been noted by GNATS.
From: "Rong-en Fan" <grafan@gmail.com>
To: bug-followup@FreeBSD.org
Cc:
Subject: Re: ports/121992: [PATCH] archivers/p5-Compress-LZW: CPAN Macro
Date: Sun, 23 Mar 2008 15:54:32 +0800
On Sun, Mar 23, 2008 at 1:17 PM, Philip M. Gollucci <pgollucci@p6m7g8.com> wrote:
> --- p5-Compress-LZW-0.01_1.patch begins here ---
> Index: Makefile
> ===================================================================
> RCS file: /home/ncvs/ports/archivers/p5-Compress-LZW/Makefile,v
> retrieving revision 1.4
> diff -u -u -r1.4 Makefile
> --- Makefile 8 Sep 2007 00:51:17 -0000 1.4
> +++ Makefile 22 Mar 2008 20:32:24 -0000
> @@ -9,7 +9,7 @@
> PORTVERSION= 0.01
> PORTREVISION= 1
> CATEGORIES= archivers perl5
> -MASTER_SITES= ${MASTER_SITE_PERL_CPAN}
> +MASTER_SITES= CPAN
> MASTER_SITE_SUBDIR= Compress
> PKGNAMEPREFIX= p5-
First, when you using CPAN, it has SUBDIR set to the correct
directory if you use module's name as PORTNAME. Second,
I'm not sure if this is a good idea to that just switch to the macro
without any version update. Usually, maintainers change to use
macros in bsd.sites.mk when there is new version available.
If perl@ thinks that we are going to use CPAN macro by default,
then perhaps change all perl@ maintained ports at once will
be better.
Regards,
Rong-En Fan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200803231130.m2NBU3VE049732>