Date: Fri, 20 Feb 2015 15:23:01 +0000 From: "nwhitehorn (Nathan Whitehorn)" <phabric-noreply@FreeBSD.org> To: freebsd-arm@freebsd.org Subject: [Differential] [Changed Subscribers] D1912: Fix endianness on FDT read in ARM GIC Message-ID: <f268f2752d3a122aa10e27c740f21ee1@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-ker5chhmevh5hyis4d47-req@FreeBSD.org> References: <differential-rev-PHID-DREV-ker5chhmevh5hyis4d47-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
nwhitehorn added a subscriber: nwhitehorn. nwhitehorn added a comment. This is a good patch. The spec defines that interrupts properties are in 32-bit chunks "encoded as with <encode-int>" (i.e. big-endian and 32-bits at a time), so all endian decoding should be confined to OF_getencprop() calls in ofw_bus_intr_to_rl(). REVISION DETAIL https://reviews.freebsd.org/D1912 To: zbb, imp, andrew Cc: nwhitehorn, onwahe-gmail-com, freebsd-arm
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f268f2752d3a122aa10e27c740f21ee1>