Date: Tue, 24 Jul 2001 17:51:48 -0700 From: Brooks Davis <brooks@one-eyed-alien.net> To: Julian Elischer <julian@elischer.org> Cc: net@freebsd.org, hackers@freebsd.org Subject: Re: review request: ng_split cleanup Message-ID: <20010724175148.A31113@Odin.AC.HMC.Edu> In-Reply-To: <Pine.BSF.4.21.0107241659100.20936-100000@InterJet.elischer.org>; from julian@elischer.org on Tue, Jul 24, 2001 at 05:04:53PM -0700 References: <20010724143734.A1412@Odin.AC.HMC.Edu> <Pine.BSF.4.21.0107241659100.20936-100000@InterJet.elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--EVF5PPMfhYS0aIcm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 24, 2001 at 05:04:53PM -0700, Julian Elischer wrote: > On Tue, 24 Jul 2001, Brooks Davis wrote: >=20 > > Index: ng_split.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > RCS file: /home/ncvs/src/sys/netgraph/ng_split.c,v > > retrieving revision 1.1 >=20 > [...] >=20 > > diff -u -r1.1 ng_split.c > > - /*=20 > > - * XXX Really here we should just remove metadata we understand. > > - */ > > - NGI_GET_META(item, meta); > > - NG_FREE_META(meta); >=20 >=20 > this one is tricky.. > it was written as part of a set of nodes that pass around their own > metadata. The original idea was (so the author suggested) to stop those= =20 > metadata structures from propogating out of the limited part of the graph= =20 > that knew about them. >=20 > However I don't see any harm in letting them go, since any node that > doesn't understand a particular metadata type should ignore it.. My idea was that split falls into the same catagory as one2many or tee in that their sole function is to move packets around and thus removing metadata was a POLA violation. It seems that if you do need to create a wall to keep metadata out, the right answer would be an ng_stripmeta node who's purpose would be to remove metadata to provide this kind of isolation where needed. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --EVF5PPMfhYS0aIcm Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE7XhgjXY6L6fI4GtQRArtOAJ9tfOxOp+G2aYkP/YWed+bnaJTE9gCgmGMi 6wAr0aINiRt7xTU3hIOSH/0= =LZiK -----END PGP SIGNATURE----- --EVF5PPMfhYS0aIcm-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010724175148.A31113>