Date: Fri, 15 Mar 2013 01:06:30 +0100 From: Guido Falsi <madpilot@FreeBSD.org> To: Eitan Adler <eadler@freebsd.org> Cc: svn-ports-head@freebsd.org, Max Brazhnikov <makc@freebsd.org>, Alexey Dokuchaev <danfe@freebsd.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r313841 - head/comms/openobex Message-ID: <51426606.3050704@FreeBSD.org> In-Reply-To: <51426349.7070003@FreeBSD.org> References: <201303102105.r2AL5C2o048218@svn.freebsd.org> <513E5682.1070704@FreeBSD.org> <20130312014941.GC92762@FreeBSD.org> <1886726.vG9fsaSg1C@mercury.ph.man.ac.uk> <CAF6rxgmaUyttnjPANbXLbJonqKGLLCOwmMY826U9g-pWMNuSYg@mail.gmail.com> <51426349.7070003@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 03/15/13 00:54, Guido Falsi wrote: > On 03/12/13 13:48, Eitan Adler wrote: >> On 12 March 2013 07:18, Max Brazhnikov <makc@freebsd.org> wrote: >>> On Tue, 12 Mar 2013 01:49:41 +0000 Alexey Dokuchaev wrote: >>>> On Mon, Mar 11, 2013 at 11:11:14PM +0100, Guido Falsi wrote: >>>>>>> Would it be feasible to make DOXYGEN default for bulk pacakge >>>>>>> building >>>>>>> cases but not for regular port users (that is, hide it behind >>>>>>> BATCH or >>>>>>> PACKAGE_BUILDING)? >>>>> >>>>> I do like your idea. >>>>> >>>>> I have tested the port with the following stanza after OPTIONS_DEFINE: >>>>> >>>>> .if !defined(BATCH) && !defined(PACKAGE_BUILDING) >>>>> OPTIONS_DEFAULT+= DOXYGEN >>>>> .endif >>>>> >>>>> It does work as expected, is this what you had in mind? >>>> >>>> Yes, exactly. >>>> >>>>> Should I check only against one of the two variables? >> >> Users will sometimes set BATCH to avoid interaction with the ports >> tree. I believe they would not expect it changes dependencies as >> well. >> PACKAGE_BUILDING seems more correct in this case. >> > > My logic was inverted, rereading danfe statement he wants DOXYGEN on for > PACKAGE_BUILDING and off for regular builds, like this: > > .if !defined(PACKAGE_BUILDING) > OPTIONS_DEFAULT+= DOXYGEN > .endif I still wrote it with inverted logic, I meant: .if defined(PACKAGE_BUILDING) OPTIONS_DEFAULT+= DOXYGEN .endif -- Guido Falsi <madpilot@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51426606.3050704>