Date: Thu, 10 Apr 2014 12:26:38 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: =?utf-8?B?UGF3ZcWCIFDEmWthbGE=?= <pawel@freebsd.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r350792 - head/emulators/tme Message-ID: <20140410102638.GE8207@ivaldir.etoilebsd.net> In-Reply-To: <20140410101619.GD8207@ivaldir.etoilebsd.net> References: <201404100911.s3A9B8BV042081@svn.freebsd.org> <BC4E068BFADC0B6D6F034A05@atuin.in.mat.cc> <20140410094640.GB8207@ivaldir.etoilebsd.net> <20140410121133.000066f7@freebsd.org> <20140410101619.GD8207@ivaldir.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--mR8QP4gmHujQHb1c Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 10, 2014 at 12:16:19PM +0200, Baptiste Daroussin wrote: > On Thu, Apr 10, 2014 at 12:11:33PM +0200, Pawe=C5=82 P=C4=99kala wrote: > > Baptiste Daroussin <bapt@FreeBSD.org> wrote: > >=20 > > > On Thu, Apr 10, 2014 at 11:39:45AM +0200, Mathieu Arnold wrote: > > > > +--On 10 avril 2014 09:11:08 +0000 Pawel Pekala <pawel@FreeBSD.org> > > > > wrote: | - Remove some dependencies pulled in automatically by > > > > others > > > >=20 > > > > Ah, that feels wrong, a port should have explicit dependencies to > > > > thing it needs to fetch/extract/build/link/run, it should not rely > > > > on some of its dependencies bringing what it needs as sub > > > > dependencies. > > > >=20 > > > Good catch I haven't seen that one > > >=20 > > > This is wrong because the day one of the deps stop pulling down a > > > dependency of this port then this port will be broken > >=20 > > All removed dependencies libraries can be found in pkg -B gtk2 output, > > which is build and run dependency (USES=3D gtk20) so I don't see any > > problem here except not clear log entry. > >=20 >=20 > The day gtk20 does not depends anymore on this you are doomed if those de= ps are > explicitly depended on by your port >=20 With a bit more of precision: 90% of the one you removed can safely be remo= ved because for sure they are not directly used by tme but exposed via gtk20 in= that case it is safe to remove them. I'm not that sure about pcre or expat for e= xample In the end to know what should be explicitly listed the right things is on freebsd 10 to look at the pkg info -B tme and only list the dependencies sh= own here. Why FreeBSD 10+ ? because on earlier version or freebsd ld(1) overlink. Even there, it won't be 100% accurate because gtk pc files it known to be respon= sible of a bit of overlinking and the way we use libtool in the ports tree is also responsible of a bit of overlinking (in particular the fast that we do keep= .la files) Anyway anything not shown by pkg info -B tme on FreeBSD 10+ can safely be removed :) (Honnestly I think in the tme case in particular you are safe after a secon= d review) regards, Bapt --mR8QP4gmHujQHb1c Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlNGcd4ACgkQ8kTtMUmk6EyWPQCeM/jePG/HRChh2Al7IkAXl5Ci r+4AoLB0ZD+1vB7cAh7CYyn4dEGQjc8v =gZMw -----END PGP SIGNATURE----- --mR8QP4gmHujQHb1c--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140410102638.GE8207>