Date: Sun, 10 Oct 2010 10:54:37 +0200 From: Ivan Voras <ivoras@freebsd.org> To: "Andrey V. Elsukov" <ae@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r213662 - in head: sbin/geom/class/concat sbin/geom/class/eli sbin/geom/class/journal sbin/geom/class/mirror sbin/geom/class/part sbin/geom/class/raid3 sbin/geom/class/shsec sbin/geom/c... Message-ID: <AANLkTikqYJ=t9mMcHAU3Si8wx08m=RxiBgBgUjLfyzGX@mail.gmail.com> In-Reply-To: <201010092020.o99KKSYW051470@svn.freebsd.org> References: <201010092020.o99KKSYW051470@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9 October 2010 22:20, Andrey V. Elsukov <ae@freebsd.org> wrote: > Author: ae > Date: Sat Oct =C2=A09 20:20:27 2010 > New Revision: 213662 > URL: http://svn.freebsd.org/changeset/base/213662 > > Log: > =C2=A0Replace strlen(_PATH_DEV) with sizeof(_PATH_DEV) - 1. Um, this looks like a pointless change and for the worse; Even at -O1 the compiler will reduce strlen(constant) to just its result and for code like printf("%d\n", sizeof("1234567")) produce code like: movl $7, %esi movl $.LC0, %edi movl $0, %eax call printf And (though tastes differ) I think the sizeof() variant is less readable. The strlen(_PATH_something) idiom is common in other parts of the kernel outside GEOM. In short - why was this done?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTikqYJ=t9mMcHAU3Si8wx08m=RxiBgBgUjLfyzGX>