Date: Sun, 1 Mar 1998 09:08:47 -0800 From: John-Mark Gurney <gurney_j@efn.org> To: "Jordan K. Hubbard" <jkh@time.cdrom.com> Cc: sos@FreeBSD.ORG, Satoshi Asami <asami@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/pci pcisupport.c Message-ID: <19980301090847.47529@hydrogen.nike.efn.org> In-Reply-To: <25256.888771661@time.cdrom.com>; from Jordan K. Hubbard on Sun, Mar 01, 1998 at 09:01:01AM -0800 References: <199803011556.QAA09093@sos.freebsd.dk> <25256.888771661@time.cdrom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Jordan K. Hubbard scribbled this message on Mar 1: > > In reply to Satoshi Asami who wrote: > > > asami 1998/03/01 02:10:32 PST > > > > > > Modified files: > > > sys/pci pcisupport.c > > > Log: > > > Add Intel 430TX chipset, namely 82439TX system controller and four > > > incarnations of 82371AB (P/I bridge, IDE, USB and power management). > > > > > > Tested by: jkh > > > > This is the weakest test I've seen for a looong time :) > > Those chips are now defined TWICE... > > Really? They certainly didn't get ID'd properly before I applied > Satoshi's patch! well... maybe your talking about RELENG_2_2... but the code is there in -current and missing from RELENG_2_2... (if you take a look at the source from before this commit)... > > Who has that pointy hat, well make it two :) > > Make it three - whomever thought they added this support before > screwed it up because it certainly didn't work. :-) probably miscommunication.... a patch for one branch shouldn't be blindly merged into another brach.... -- John-Mark Gurney Modem/FAX: +1 541 683 6954 Cu Networking P.O. Box 5693, 97405 Live in Peace, destroy Micro$oft, support free software, run FreeBSD Don't trust anyone you don't have the source for To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19980301090847.47529>