Date: Mon, 8 Jan 2007 01:08:24 +0000 (UTC) From: Marius Strobl <marius@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/sparc64/pci ofw_pcibus.c Message-ID: <200701080108.l0818OfQ094702@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
marius 2007-01-08 01:08:24 UTC
FreeBSD src repository
Modified files:
sys/sparc64/pci ofw_pcibus.c
Log:
In ofw_pcibus_attach() skip dupe PCI devices reported by the
firmware (mainly 'pmu' and its 'lomp' dupe found in a couple of
later USII{e,i}-based machines) by checking whether a device with
the same triple of bus number, slot and function already has been
added. This is the simple yet effective approach introduced in
OpenBSD some time ago, but which has the flaw that it assumes
that the device and its dupe(s) found in the OFW device tree are
equal or at least the one encountered first is in some way the
more important one (this is the case with 'pmu' and 'lomp'; the
'pmu' node has couple of properties and children while the 'lomp'
one misses most of these). If there's ever a device/dupe pair
where we don't encounter the more important node first, we'll
probably need to introduce a quirk list in order to add the
desired device but prevent its dupe(s) from being added.
MFC after: 1 week
Revision Changes Path
1.12 +2 -0 src/sys/sparc64/pci/ofw_pcibus.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200701080108.l0818OfQ094702>