Date: Mon, 16 Mar 2009 15:21:50 +0900 From: Weongyo Jeong <weongyo.jeong@gmail.com> To: Robert Watson <rwatson@freebsd.org> Cc: usb@freebsd.org, Hans Petter Selasky <hselasky@freebsd.org>, thompsa@freebsd.org Subject: Re: USB support in NDIS -- IFF_NEEDSGIANT? Message-ID: <20090316062150.GC1851@weongyo.cdnetworks.kr> In-Reply-To: <alpine.BSF.2.00.0903131136500.61873@fledge.watson.org> References: <alpine.BSF.2.00.0902161129060.5806@fledge.watson.org> <20090217052121.GB86244@weongyo.cdnetworks.kr> <alpine.BSF.2.00.0903131136500.61873@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Mar 13, 2009 at 11:37:57AM +0000, Robert Watson wrote: > > On Tue, 17 Feb 2009, Weongyo Jeong wrote: > > >>As you know, I've been gradually working to eliminate all non-MPSAFE > >>network device driver infrastructure for 8.0, having removed non-MPSAFE > >>network protocol infrastructure in 7.0. In reviewing remaining drivers > >>using IFF_NEEDSGIANT, I spotted this in the NDIS code: > ... > >>Having taken a glance, it looks like this was added specifically to > >>support > >>USB devices attached via NDIS. > > > >AFAIK all of usb wireless drivers had it so I couldn't avoid it when I had > >implemented. > > > >>With the new USB code, are NDIS drivers still supported? > > > >I think that it would be supported at 8.0 > > > >>And in the new world order, is this IFF_NEEDSGIANT still required? > > > >Probably we can remove the IFF_NEEDSGIANT flags at the new USB code. > > > >>Can I simply remove it once the old USB code is on the way out the door? > > > >IMHO yes I think. > > Dear all: > > A few weeks have passed, so I wanted to check in and see how this project > was going -- are we at a point yet where removing IFF_NEEDSGIANT won't > cause significant loss of functionality? In the current, NDIS USB porting almost have completed and it doesn't use IFF_NEEDSGIANT anymore. With some tests it looks it works well so I think it wouldn't cause any loss of functionality. regards, Weongyo Jeong
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090316062150.GC1851>