Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 2 Aug 2003 11:31:45 +0800 (CST)
From:      "Ying-Chieh Chen" <yinjieh@csie.nctu.edu.tw>
To:        FreeBSD-gnats-submit@FreeBSD.org
Cc:        wjv@FreeBSD.org
Subject:   ports/55176: [Update port] fix pkg-req in textproc/py-xml to handle specified output
Message-ID:  <200308020331.h723VjUI045334@alumni.csie.nctu.edu.tw>
Resent-Message-ID: <200308020340.h723eEi7022430@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         55176
>Category:       ports
>Synopsis:       [Update port] fix pkg-req in textproc/py-xml to handle specified output
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Fri Aug 01 20:40:13 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator:     Ying-Chieh Chen
>Release:        FreeBSD 4.8-RELEASE i386
>Organization:
yinjieh vmware lab
>Environment:
System: FreeBSD stable.yinjieh.com 4.8-RELEASE FreeBSD 4.8-RELEASE #0: Thu Apr 3 10:53:38 GMT 2003 root@freebsd-stable.sentex.ca:/usr/obj/usr/src/sys/GENERIC i386


	
>Description:

	In textproc/py-xml/pkg-req, it checks the following expression:

	python -c 'import string, sys; print string.split(sys.version)[0] >= "2.0"'

	If the output of the expression is "1", it passes the test.
	But when I installed python-2.3, I found that the expression will output "True".
	For compatibility reason, I modify pkg-req to check whether the output is "1" or "True", it means the same.

	If the maintainer think this patch ok, please follow this.
	Thanks!

>How-To-Repeat:

	cd ${PORTSDIR}/textproc/py-xml && make install

>Fix:

	

--- py-xml.patch begins here ---
diff -ruN /usr/ports/textproc/py-xml/pkg-req py-xml/pkg-req
--- /usr/ports/textproc/py-xml/pkg-req	Wed Sep 18 20:25:25 2002
+++ py-xml/pkg-req	Sat Aug  2 10:52:13 2003
@@ -5,7 +5,7 @@
 if [ "x$1" = "xINSTALL" -o "x$2" = "xINSTALL" ]; then
   PYTHON_GT=`python -c 'import string, sys; \
                         print string.split(sys.version)[0] >= "2.0"'`
-  if [ "x${PYTHON_GT}" = "x1" ]; then
+  if [ "x${PYTHON_GT}" = "x1" -o "x${PYTHON_GT}" = "xTrue" ]; then
     exit 0
   else
     echo "-----------------------------------------------------------"
--- py-xml.patch ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200308020331.h723VjUI045334>