Date: Tue, 14 Mar 2006 11:27:24 -0800 From: Maksim Yevmenkin <maksim.yevmenkin@savvis.net> To: Iain Hibbert <plunky@rya-online.net> Cc: freebsd-bluetooth@freebsd.org Subject: Re: config files Message-ID: <4417191C.8030501@savvis.net> In-Reply-To: <1142364014.786820.1535.nullmailer@galant.ukfsn.org> References: <1141918855.418446.1437.nullmailer@galant.ukfsn.org> <44107678.1080206@savvis.net> <1142195365.759631.5369.nullmailer@galant.ukfsn.org> <44160BE9.9020306@savvis.net> <1142325762.357474.659.nullmailer@galant.ukfsn.org> <44170ADD.3080706@savvis.net> <1142364014.786820.1535.nullmailer@galant.ukfsn.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Iain Hibbert wrote: > On Tue, 14 Mar 2006, Maksim Yevmenkin wrote: > > >>> sa.l2cap_psm = htole16(NG_L2CAP_PSM_SDP); >>> >>>which seems wrong? (will work ok on little endian machine) >> >>actually, no. i think the problem is with bthidd(8) (and others, i.e. >>sdpd(8)). bluetooth byte order is le16. so, l2cap_psm field in sockaddr_l2cap >>should always be in le16 byte order. >> >>thanks for catching this! > > Yes, in the packet, psm is le16 but in the sockaddr it should be host > order, surely? It makes no sense to preserve byte ordering in a channel > number.. well, not in freebsd. just like in sockaddr_in port/ip have to passed (to kernel) in network byte order, psm in sockaddr_l2cap has to be passed (to kernel) in le16 byte order. >>> + sas.sa_handler = sighup; >> >>this is obviously a typo. it should be "sa.sa_handler = sighup;". otherwise it >>wont compile. did you sent the patch before you have actually tried it? > > Whoops, the version I have consists of a some other changes not relevant > to FreeBSD (wscons stuff) and so to make that patch, I had to do a bit of > cut and paste (and, I can't compile the unchanged version).. but it is > working for me with no strange effects that I can detect. i see. thanks, max
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4417191C.8030501>