Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 27 Nov 2014 17:39:09 +0000
From:      bugzilla-noreply@freebsd.org
To:        gnome@FreeBSD.org
Subject:   maintainer-feedback requested: [Bug 195452] editors/abiword: probably incorrect option group handling
Message-ID:  <bug-195452-6497-5FjfZ5NqXz@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-195452-6497@https.bugs.freebsd.org/bugzilla/>
References:  <bug-195452-6497@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
Dmitry Marakasov <amdmi3@FreeBSD.org> has asked gnome@FreeBSD.org for
maintainer-feedback:
Bug 195452: editors/abiword: probably incorrect option group handling
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D195452



--- Description ---
abiword has options group named COLLAB:

OPTIONS_GROUP=3D	COLLAB
OPTIONS_GROUP_COLLAB=3D	COLXMPP

however group name is mentioned in OPTIONS_DEFAULT:

OPTIONS_DEFAULT=3DSPELLCHECK CLIPART TEMPLATES COLLAB

and is checked later

.if ${PORT_OPTIONS:MCOLLAB}
CONFIGURE_ARGS+=3D--with-boost --enable-collab-backend-tcp \
		--enable-collab-backend-service
BUILD_DEPENDS+=3D ${LOCALBASE}/include/asio.hpp:${PORTSDIR}/net/asio
LIB_DEPENDS+=3D	libboost_system.so:${PORTSDIR}/devel/boost-libs \
		libsoup-2.4.so:${PORTSDIR}/devel/libsoup \
		libgnutls.so:${PORTSDIR}/security/gnutls
RUN_DEPENDS+=3D	${LOCALBASE}/include/asio.hpp:${PORTSDIR}/net/asio
PLIST_SUB+=3D		COLLAB=3D""
.else
CONFIGURE_ARGS+=3D--without-boost --disable-collab-backend-tcp \
		--disable-collab-backend-service
PLIST_SUB+=3D		COLLAB=3D"@comment "
.endif

this seems to be incorrect - I haven't digged into the logic, but probably
COLXMPP which belongs to COLLAB group should be mentioned in OPTIONS_DEFAULT
and checked instead.

--- Comment #1 from Bugzilla Automation <bugzilla@FreeBSD.org> ---
Auto-assigned to maintainer gnome@FreeBSD.org=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-195452-6497-5FjfZ5NqXz>