Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 21 Sep 2008 22:51:47 GMT
From:      Peter Wemm <peter@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 150242 for review
Message-ID:  <200809212251.m8LMplQs062841@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=150242

Change 150242 by peter@peter_overcee on 2008/09/21 22:51:38

	It would be helpful if ata didn't panic when doing a printf() about a read error.

Affected files ...

.. //depot/projects/hammer/sys/dev/ata/ata-queue.c#39 edit

Differences ...

==== //depot/projects/hammer/sys/dev/ata/ata-queue.c#39 (text+ko) ====

@@ -357,9 +357,11 @@
 			      "\6MEDIA_CHANGED\5NID_NOT_FOUND"
 			      "\4MEDIA_CHANGE_REQEST"
 			      "\3ABORTED\2NO_MEDIA\1ILLEGAL_LENGTH");
+	if (request->dma) {
 		if ((request->flags & ATA_R_DMA) &&
 		    (request->dma->status & ATA_BMSTAT_ERROR))
 		    printf(" dma=0x%02x", request->dma->status);
+	}
 		if (!(request->flags & (ATA_R_ATAPI | ATA_R_CONTROL)))
 		    printf(" LBA=%ju", request->u.ata.lba);
 		printf("\n");



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200809212251.m8LMplQs062841>