Date: Sat, 30 Jul 2016 17:54:39 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 204602] parse() in boot loader interp_parse.c is too naive about quotes Message-ID: <bug-204602-8-bnMZu4Z1CF@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-204602-8@https.bugs.freebsd.org/bugzilla/> References: <bug-204602-8@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D204602 --- Comment #1 from commit-hook@freebsd.org --- A commit references this bug: Author: allanjude Date: Sat Jul 30 17:53:37 UTC 2016 New revision: 303556 URL: https://svnweb.freebsd.org/changeset/base/303556 Log: Improve boot loader quote parsing parse() is the boot loader's interp_parse.c is too naive about quotes both single and double quotes were allowed to be mixed, and single quotes did not follow the usual semantics (re variable expansion). The old code did not check for terminating quotes This update implements: * distinguishing single and double quote * variable expansion will not be done inside single quote protected area * will preserve inner quote for values like "value 'some list'" * ending quote check. this diff does not implement ending quote order check, it shouldn't be too hard, needs some improvements on parser state machine. PR: 204602 Submitted by: Toomas Soome <tsoome@me.com> Relnotes: yes Differential Revision: https://reviews.freebsd.org/D6000 Changes: head/sys/boot/common/interp_parse.c --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-204602-8-bnMZu4Z1CF>