Date: Tue, 15 Apr 2014 09:45:00 +0200 From: Tijl Coosemans <tijl@FreeBSD.org> To: Boris Samorodov <bsam@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r350154 - head/print/cups-base Message-ID: <20140415094500.7ee3f9fb@kalimero.tijl.coosemans.org> In-Reply-To: <201404041927.s34JRqvF052403@svn.freebsd.org> References: <201404041927.s34JRqvF052403@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 4 Apr 2014 19:27:52 +0000 (UTC) Boris Samorodov wrote: > Author: bsam > Date: Fri Apr 4 19:27:51 2014 > New Revision: 350154 > URL: http://svnweb.freebsd.org/changeset/ports/350154 > QAT: https://qat.redports.org/buildarchive/r350154/ > > Log: > Use CFLAGS+=-fno-blocks to unbreak systems with default gcc compiler. > This is a band-aid that should be reworked for systems with blocks > and libdispatch support. > > Reported by: Anton Shterenlikht <mexas@bris.ac.uk> > Discussed at: freebsd-ports@ > MFH: 2014Q2 > > Modified: > head/print/cups-base/Makefile > > Modified: head/print/cups-base/Makefile > ============================================================================== > --- head/print/cups-base/Makefile Fri Apr 4 19:27:02 2014 (r350153) > +++ head/print/cups-base/Makefile Fri Apr 4 19:27:51 2014 (r350154) > @@ -299,4 +299,12 @@ post-install: > ${INSTALL_SCRIPT} ${WRKDIR}/ulpt-cupsd.sh ${STAGEDIR}${PREFIX}/sbin/ > .endif > > -.include <bsd.port.mk> > +# This is just a band-aid to unbreak print/cups-client at systems with default gcc compiler, > +# should be reworked to build with blocks and libdispatch support (via options). > +# > +.include <bsd.port.pre.mk> > +.if defined(CUPS_CLIENT) && ${OPSYS} == "FreeBSD" && ${OSVERSION} > 1000000 > +CFLAGS+= -fno-blocks > +.endif > + > +.include <bsd.port.post.mk> I think you need to patch /usr/local/include/cups/cups.h as well because otherwise every port that uses it also needs this .if block.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140415094500.7ee3f9fb>