Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 09 Jul 1998 10:32:37 +0200
From:      Poul-Henning Kamp <phk@critter.freebsd.dk>
To:        smoergrd@oslo.geco-prakla.slb.com (Dag-Erling Coidan Smørgrav)
Cc:        akiyama@kme.mei.co.jp, freebsd-bugs@FreeBSD.ORG
Subject:   Re: kern/7210 
Message-ID:  <6661.899973157@critter.freebsd.dk>
In-Reply-To: Your message of "09 Jul 1998 10:22:50 %2B0200." <rx4sokbzb51.fsf@oslo.geco-prakla.slb.com> 

next in thread | previous in thread | raw e-mail | index | archive | help
In message <rx4sokbzb51.fsf@oslo.geco-prakla.slb.com>, Dag-Erling Coidan Smørgra
v writes:
>Poul-Henning Kamp <phk@freebsd.org> writes:
>> Synopsis: [PATCH] od(4) bug fixes and enhancements, including LF-D100 DVD-RAM drive support.
>> 
>> State-Changed-From-To: open-closed
>> State-Changed-By: phk
>> State-Changed-When: Wed Jul 8 23:27:12 PDT 1998
>> State-Changed-Why: 
>> please don't mix three so different things in the same patch
>> please resubmit as three PRs
>
>Poul-Henning, as much as I appreciate the need to reduce the number of
>PRs, I think this was a little gratuitous. The patch fixes at least
>two serious (and related) bugs in the od driver, and should be treated
>a little more seriously.

Yes, which I why I ask the submitter to split it for us.  Experience
has shown that "jumbo patches" never get touched, whereas patches
that solve one problem only are much more likely to be fixed.

there for the

	"please resubmit as three PRs"

reply.

--
Poul-Henning Kamp             FreeBSD coreteam member
phk@FreeBSD.ORG               "Real hackers run -current on their laptop."
"ttyv0" -- What UNIX calls a $20K state-of-the-art, 3D, hi-res color terminal

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6661.899973157>