Date: Mon, 12 Apr 2004 23:40:55 +0200 (CEST) From: Dimitry Andric <dimitry@andric.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/65468: zsh 4.2.0 port incorrectly registers TCP functions if NOSHARED=yes Message-ID: <20040412214055.5FE6722864@tensor.xs4all.nl> Resent-Message-ID: <200404122150.i3CLoFvl019942@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 65468
>Category: ports
>Synopsis: zsh 4.2.0 port incorrectly registers TCP functions if NOSHARED=yes
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Apr 12 14:50:14 PDT 2004
>Closed-Date:
>Last-Modified:
>Originator: Dimitry Andric
>Release: FreeBSD 5.2-CURRENT i386
>Organization:
n/a
>Environment:
System: FreeBSD tensor.xs4all.nl 5.2-CURRENT FreeBSD 5.2-CURRENT #0: Thu Mar 18 09:04:06 CET 2004 dim@vfbsd5.dim:/usr/obj/usr/src/sys/TENSOR i386
>Description:
When you install the zsh 4.2.0 port using NOSHARED=yes, to get a
statically linked version, the tcp module is not compiled, just as
some other dynamic-only modules. Therefore, the TCP functions in
Functions/TCP are not installed by the main Makefile. However, they
are still listed in the pkg-plist file, so packaging the port will
fail, and uninstalling the port will complain about non-existing files
in ${PREFIX}/share/zsh/4.0.2/functions/TCP.
>How-To-Repeat:
cd ${PORTSDIR}/shells/zsh
make NOSHARED=yes package
make NOSHARED=yes deinstall
>Fix:
Simply put %%NO_STATIC%% in front of all functions/TCP related stuff.
Here is a patch.
diff -urNd zsh/pkg-plist zsh.dim/pkg-plist
--- zsh/pkg-plist Sat Apr 10 13:57:52 2004
+++ zsh.dim/pkg-plist Mon Apr 12 23:23:07 2004
@@ -552,24 +552,24 @@
%%ZSH_FNDIR%%/Prompts/prompt_walters_setup
%%ZSH_FNDIR%%/Prompts/prompt_zefram_setup
%%ZSH_FNDIR%%/Prompts/promptinit
-%%ZSH_FNDIR%%/TCP/tcp_alias
-%%ZSH_FNDIR%%/TCP/tcp_close
-%%ZSH_FNDIR%%/TCP/tcp_command
-%%ZSH_FNDIR%%/TCP/tcp_expect
-%%ZSH_FNDIR%%/TCP/tcp_fd_handler
-%%ZSH_FNDIR%%/TCP/tcp_log
-%%ZSH_FNDIR%%/TCP/tcp_open
-%%ZSH_FNDIR%%/TCP/tcp_output
-%%ZSH_FNDIR%%/TCP/tcp_point
-%%ZSH_FNDIR%%/TCP/tcp_proxy
-%%ZSH_FNDIR%%/TCP/tcp_read
-%%ZSH_FNDIR%%/TCP/tcp_rename
-%%ZSH_FNDIR%%/TCP/tcp_send
-%%ZSH_FNDIR%%/TCP/tcp_sess
-%%ZSH_FNDIR%%/TCP/tcp_shoot
-%%ZSH_FNDIR%%/TCP/tcp_spam
-%%ZSH_FNDIR%%/TCP/tcp_talk
-%%ZSH_FNDIR%%/TCP/tcp_wait
+%%NO_STATIC%%%%ZSH_FNDIR%%/TCP/tcp_alias
+%%NO_STATIC%%%%ZSH_FNDIR%%/TCP/tcp_close
+%%NO_STATIC%%%%ZSH_FNDIR%%/TCP/tcp_command
+%%NO_STATIC%%%%ZSH_FNDIR%%/TCP/tcp_expect
+%%NO_STATIC%%%%ZSH_FNDIR%%/TCP/tcp_fd_handler
+%%NO_STATIC%%%%ZSH_FNDIR%%/TCP/tcp_log
+%%NO_STATIC%%%%ZSH_FNDIR%%/TCP/tcp_open
+%%NO_STATIC%%%%ZSH_FNDIR%%/TCP/tcp_output
+%%NO_STATIC%%%%ZSH_FNDIR%%/TCP/tcp_point
+%%NO_STATIC%%%%ZSH_FNDIR%%/TCP/tcp_proxy
+%%NO_STATIC%%%%ZSH_FNDIR%%/TCP/tcp_read
+%%NO_STATIC%%%%ZSH_FNDIR%%/TCP/tcp_rename
+%%NO_STATIC%%%%ZSH_FNDIR%%/TCP/tcp_send
+%%NO_STATIC%%%%ZSH_FNDIR%%/TCP/tcp_sess
+%%NO_STATIC%%%%ZSH_FNDIR%%/TCP/tcp_shoot
+%%NO_STATIC%%%%ZSH_FNDIR%%/TCP/tcp_spam
+%%NO_STATIC%%%%ZSH_FNDIR%%/TCP/tcp_talk
+%%NO_STATIC%%%%ZSH_FNDIR%%/TCP/tcp_wait
%%ZSH_FNDIR%%/Zle/backward-kill-word-match
%%ZSH_FNDIR%%/Zle/backward-word-match
%%ZSH_FNDIR%%/Zle/capitalize-word-match
@@ -645,7 +645,7 @@
@dirrm %%ZSH_FNDIR%%/MIME
@dirrm %%ZSH_FNDIR%%/Misc
@dirrm %%ZSH_FNDIR%%/Prompts
-@dirrm %%ZSH_FNDIR%%/TCP
+%%NO_STATIC%%@dirrm %%ZSH_FNDIR%%/TCP
@dirrm %%ZSH_FNDIR%%/Zle
@dirrm %%ZSH_FNDIR%%
@dirrm %%DATADIR%%/%%ZSH_VER%%
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040412214055.5FE6722864>