Date: Tue, 2 Apr 1996 14:12:29 -0700 (MST) From: Terry Lambert <terry@lambert.org> To: count@key.hole.fi (Bror 'Count' Heinola) Cc: joerg_wunsch@uriah.heep.sax.de, freebsd-current@FreeBSD.ORG Subject: Re: Fixit Floppy Broken? Message-ID: <199604022112.OAA17134@phaeton.artisoft.com> In-Reply-To: <199604020813.LAA04262@key.hole.fi> from "Bror 'Count' Heinola" at Apr 2, 96 11:13:27 am
next in thread | previous in thread | raw e-mail | index | archive | help
> > Filing a PR won't help very much. The floppy driver is in bad need > > for a rewrite. > > > > If you're willing to rewrite it, and submitting PRs would accelerate > > this process, i could immediately submit half a dozen PRs for it. :-) > > Hey, couldn't 'we' use the magnificent dancing and whistling > fd driver made by Jesus Monroy Jr. ? :-) >From what I could tell looking at it, it was decent code. He had one bad bug... and it seemed to be more of an architectural ordering bug (he wanted to do something one way, and the controller manufactureres wanted him to reverse the logic for it to work). Changing the ordering would have required a timeout in order to retry to eliminate a race window. But the code did not suck, even if many of his ideas were off the wall. Terry Lambert terry@lambert.org --- Any opinions in this posting are my own and not those of my present or previous employers.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199604022112.OAA17134>