Date: Sun, 22 Sep 2013 17:55:28 -0700 From: David Wolfskill <david@catwhisker.org> To: freebsd-ports@freebsd.org Subject: Help understanding ports tinderbox failure report? Message-ID: <20130923005528.GA1616@albert.catwhisker.org>
next in thread | raw e-mail | index | archive | help
--kXdP64Ggrk/fb43R Content-Type: multipart/mixed; boundary="u3/rZRmxL6MmkK24" Content-Disposition: inline --u3/rZRmxL6MmkK24 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Back in July, I filed PR ports/180642 (as the port maintainer for astro/gpsman) to update that port from 6.4.4 to 6.4.4.1. astro/gpsman is a tcl/Tk application; recently, a request was made to update such ports from "USE_TK_RUN" to "USES+=3D tk,run" (for example. In the process of doing that, I discovered that the patch in ports/180642 had never been committed. So I took a look at <http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/180642>, and found -- much to my surprise -- that a tinderbox run had apparently encountered a problem if "NOPORTDOCS=3Dyes" had been specified. (I had not been informed of this because there was a typo in my email address.) I'm not familiar with interpreting ports tinderbox reports, but the complaint appears to be that if "NOPORTDOCS=3Dyes" is specified, the deinstallation of the port leaves (lots of) files behind. Now, I don't have ports-mgmt/tinderbox installed on my laptop; "make missing" shows that several prerequisite ports are not installed. But the application is fairly stand-alone: I can afford to deinstall & reinstall it. So I deinstalled the port, appended "NOPORTDOCS=3Dyes" to /etc/make.conf, installed the port (no problem, except that the pkg-message advised me to go look at some files that weren't installed because of the "NOPORTDOCS=3Dyes"). I then used pkg_delete to remove the port, and there was no trace of the files that tinderbox whined about. So I'm fairly confused at this point. I recall having paid a moderate amount of attention to ensuring that the pkg-plist was constructed properly, but looking at the port, it's not there. A review of the svn log for the Makefile shows the entry: ------------------------------------------------------------------------ r295739 | jgh | 2012-04-30 14:22:11 -0700 (Mon, 30 Apr 2012) | 8 lines - Update to 6.4.3 [1] - while here, drop pkg-plist and use PORT{DOCS,DATA} [2] - substitute on pkg-message, and actually show it [2] - tighten Makefile instructions, and reduce number of MKDIRS [2] PR: ports/167432 Submitted by: maintainer, david@catwhisker.org [1], jgh@[2] ------------------------------------------------------------------------ I did tweak the Makefile a bit so if "NOPORTDOCS=3Dyes" is specified, it won't add "pkg-message" to SUB_FILES; thus, it no longer attempts to advise folks who specified "NOPORTDOCS=3Dyes" to go look at files that aren't there. (I think that's an improvement.) And whatever caused the problem that tinderbox is reporting, I can't really imagine that it originated with the patch provided for the 6.4.4 -> 6.4.4.1 upgrade. I've attached a revised patch, to: * Perform the 6.4.4 -> 6.4.4.1 upgrade. * Replace the "USE_TK_RUN" (& "USE_TK_WRAPPER") with "USES+=3D tk:wrapper,r= un". * Avoid showing the pkg-message if NOPORTDOCS is defined. (The pkg-message merely directs the installer to look at installed port documentation, so it's not very useful if NOPORTDOCS is defined.) How can I fix this so it's commitable? Peace, david --=20 David H. Wolfskill david@catwhisker.org Taliban: Evil cowards with guns afraid of truth from a 14-year old girl. See http://www.catwhisker.org/~david/publickey.gpg for my public key. --u3/rZRmxL6MmkK24 Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=gpsman_patch Content-Transfer-Encoding: quoted-printable Index: gpsman/Makefile =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- gpsman/Makefile (revision 327861) +++ gpsman/Makefile (working copy) @@ -1,8 +1,8 @@ -# Created by: David Wolfskill +# Created by: David Wolfskill <david@catwhisker.org> # $FreeBSD$ =20 PORTNAME=3D gpsman -PORTVERSION=3D 6.4.4 +PORTVERSION=3D 6.4.4.1 CATEGORIES=3D astro tk geography MASTER_SITES=3D SF/${PORTNAME}/distrib EXTRACT_SUFX=3D .tgz @@ -10,11 +10,12 @@ MAINTAINER=3D david@catwhisker.org COMMENT=3D A Tcl/Tk-based GPS management utility =20 -USE_TK_RUN=3D 84+ +USES+=3D tk:wrapper,run =20 WRKSRC=3D ${WRKDIR}/${PORTNAME}-${PORTVERSION} +.if !defined(NOPORTDOCS) SUB_FILES=3D pkg-message -NO_STAGE=3D yes +.endif NO_BUILD=3D yes PORTDOCS=3D * PORTDATA=3D * Index: gpsman/distinfo =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- gpsman/distinfo (revision 327861) +++ gpsman/distinfo (working copy) @@ -1,2 +1,2 @@ -SHA256 (gpsman-6.4.4.tgz) =3D b7a6f94d24dfd47507240fd0f1e3db94305ca8485c31= db3a9fbf9637656027fe -SIZE (gpsman-6.4.4.tgz) =3D 1418214 +SHA256 (gpsman-6.4.4.1.tgz) =3D 214a8dbb3d8e0b0b798fc0cb1a422764d8747cd431= 105d55d54308d5deb9910c +SIZE (gpsman-6.4.4.1.tgz) =3D 1417223 Index: gpsman/files/patch-gpsman.tcl =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- gpsman/files/patch-gpsman.tcl (revision 327861) +++ gpsman/files/patch-gpsman.tcl (working copy) @@ -3,14 +3,6 @@ diff -ruN gpsman.tcl gpsman.tcl --- gpsman.tcl Tue May 9 02:37:24 2006 +++ gpsman.tcl Wed May 10 17:56:02 2006 -@@ -1,6 +1,6 @@ - #!/bin/sh - # This is a Tcl/Tk script to be interpreted by wish (Tk8.3 or better): \ --exec wish "$0" -- "$@" -+exec wish8.4 "$0" -- "$@" -=20 - # - # gpsman --- GPS Manager: a manager for GPS receiver data @@ -247,7 +247,7 @@ } =20 Index: gpsman/pkg-descr =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- gpsman/pkg-descr (revision 327861) +++ gpsman/pkg-descr (working copy) @@ -5,4 +5,4 @@ logging information in NMEA from any GPS receiver. =20 Author: Miguel Filgueiras -WWW: http://gpsman.sourceforge.net/ +WWW: http://gpsman.sourceforge.net/ --u3/rZRmxL6MmkK24-- --kXdP64Ggrk/fb43R Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.21 (FreeBSD) iEYEARECAAYFAlI/kX8ACgkQmprOCmdXAD3jGACfTE6bYBsAqLbh3NXj4bwm8MtI x+wAmwcGRGQpY+ZBs5MZNEVgR2nDMxUN =SGPq -----END PGP SIGNATURE----- --kXdP64Ggrk/fb43R--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130923005528.GA1616>