Date: Thu, 10 Jun 2010 23:05:22 +1000 From: Lawrence Stewart <lstewart@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: freebsd-current@freebsd.org Subject: Re: [RFC] Macro to sum DPCPU vars Message-ID: <4C10E312.7040600@freebsd.org> In-Reply-To: <201006100823.52415.jhb@freebsd.org> References: <4C10620D.7070904@freebsd.org> <201006100823.52415.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 06/10/10 22:23, John Baldwin wrote: > On Wednesday 09 June 2010 11:54:53 pm Lawrence Stewart wrote: >> Does anyone have objections to or feedback on the following patch? The >> macro simplifies the act of calculating an aggregate from DPCPU counters. >> >> > http://people.freebsd.org/~lstewart/patches/tcp_ffcaia2008/dpcpu_sum_9.x.r208900.patch >> >> If anyone is curious how you would use it, take a look at: > > I think this is fine, though I'm about to make it smaller. At Robert's > request I've come up with some macros to iterate over CPUs to abstract out the > CPU_ABSENT(), etc. bits. It is at www.freebsd.org/~jhb/patches/cpu_iter.patch > Using CPU_FOREACH() should try your macro down slightly. Nice, I'll rework my patch and commit once your new bits hit the tree. Cheers, Lawrence
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C10E312.7040600>