Date: Wed, 08 Jul 1998 15:01:38 +0100 From: Roger Hardiman <roger@cs.strath.ac.uk> To: Amancio Hasty <hasty@rah.star-gate.com> Cc: freebsd-multimedia@FreeBSD.ORG Subject: Re: bt848 driver will be checked in this Friday Message-ID: <35A37BC2.2781@cs.strath.ac.uk> References: <199807070553.WAA00729@rah.star-gate.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Amancio,
I've got a partial patch for the development bt848 driver before you
commit.
It looks like you modified the Hauppauge Tuner logic to
a) select the right tuner if the EEPROM can be decoded
b) if the EEPROM cannot be decoded, do what it did before (
ie pick NTSC if the NTSC i2c address is working and TEMIC PAL if its
i2c address is working.
Plan b) fails, due to a small bug in the 1.37 driver.
I have a fix for you.
You need to add this default: to the following switch statement
switch (code) {
case 0x1:
bktr->card.tuner = &tuners[ PHILIPS_NTSC ];
goto checkDBX;
case 0x101:
bktr->card.tuner = &tuners[ PHILIPS_FR1236_NTSC ];
goto checkDBX;
case 0x2:
bktr->card.tuner = &tuners[ TEMIC_PAL ];
goto checkDBX;
case 0x202:
bktr->card.tuner = &tuners[ PHILIPS_FR1216_PAL];
goto checkDBX;
default:
if ( i2cRead( bktr, TEMIC_PALI_RADDR ) != ABSENT ) {
bktr->card.tuner = &tuners[ TEMIC_PAL ];
goto checkDBX;
}
You can then also delete the line
bktr->card.tuner = &tuners[ TEMIC_PAL ];
which comes immediatly after
if ( card == CARD_HAUPPAUGE ) {
because setting this default to PAL is no use. It gets overridden
by the final setting to NONE which comes at the end of the Tuner
section.
Bye
Roger
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-multimedia" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?35A37BC2.2781>