Date: Tue, 5 Oct 2004 09:13:51 +0930 From: Greg 'groggy' Lehey <grog@FreeBSD.org> To: "M. Warner Losh" <imp@bsdimp.com> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_shutdown.c Message-ID: <20041004234351.GD75289@wantadilla.lemis.com> In-Reply-To: <20041004.163808.73381384.imp@bsdimp.com> References: <200410041313.i94DDN1w064795@repoman.freebsd.org> <20041004.095538.105191591.imp@bsdimp.com> <20041004223426.GJ460@wantadilla.lemis.com> <20041004.163808.73381384.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--11Y7aswkeuHtSBEs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Monday, 4 October 2004 at 16:38:08 -0600, M. Warner Losh wrote: > In message: <20041004223426.GJ460@wantadilla.lemis.com> > "Greg 'groggy' Lehey" <grog@FreeBSD.org> writes: >> On Monday, 4 October 2004 at 9:55:38 -0600, M. Warner Losh wrote: >>> In message: <200410041313.i94DDN1w064795@repoman.freebsd.org> >>> Poul-Henning Kamp <phk@FreeBSD.org> writes: >>>> phk 2004-10-04 13:13:23 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: >>>> sys/kern kern_shutdown.c >>>> Log: >>>> Change the perfectly precise message >>>> printf("No buffers busy after final sync"); >>>> to >>>> printf("All buffers synced."); >>>> in order to not leave the users wondering if there should be. >>> >>> Any not reason to delete >>> printf("All buffers synced."); >>> entirely? >> >> I like to see some message to confirm that the process is over and >> done with. Something goes wrong often enough that it's good to know >> that it worked this time. > > The machine will either shutoff, reboot or print the 'hit any key to > reboot' message in addition. ... assuming everything works correctly. > Do we really need an additional message saying that we did the right > thing? No. If it always works, that's fine. I've had too many cases where it didn't, though. I can't see that it does any harm to state the fact. Greg -- See complete headers for address and phone numbers. --11Y7aswkeuHtSBEs Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBYeA3IubykFB6QiMRAsrrAJ9HEf461RLx2+Ucw0W+gWFw2oKXjgCcCdCd FA8VDNNTixC2Tf0a66+uXWQ= =15FM -----END PGP SIGNATURE----- --11Y7aswkeuHtSBEs--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041004234351.GD75289>