Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 3 Nov 2013 14:00:17 +0000 (UTC)
From:      Michael Tuexen <tuexen@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r257574 - head/sys/netinet
Message-ID:  <201311031400.rA3E0H4x090897@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: tuexen
Date: Sun Nov  3 14:00:17 2013
New Revision: 257574
URL: http://svnweb.freebsd.org/changeset/base/257574

Log:
  Unlock the lock before destroying it.
  This issue was reported by Andrew Galante.
  
  MFC after: 3 days

Modified:
  head/sys/netinet/sctp_pcb.c

Modified: head/sys/netinet/sctp_pcb.c
==============================================================================
--- head/sys/netinet/sctp_pcb.c	Sun Nov  3 13:06:43 2013	(r257573)
+++ head/sys/netinet/sctp_pcb.c	Sun Nov  3 14:00:17 2013	(r257574)
@@ -4332,6 +4332,7 @@ sctp_aloc_assoc(struct sctp_inpcb *inp, 
 			asoc->nr_mapping_array = NULL;
 		}
 		SCTP_DECR_ASOC_COUNT();
+		SCTP_TCB_UNLOCK(stcb);
 		SCTP_TCB_LOCK_DESTROY(stcb);
 		SCTP_TCB_SEND_LOCK_DESTROY(stcb);
 		LIST_REMOVE(stcb, sctp_tcbasocidhash);
@@ -5134,6 +5135,7 @@ sctp_free_assoc(struct sctp_inpcb *inp, 
 	/* Insert new items here :> */
 
 	/* Get rid of LOCK */
+	SCTP_TCB_UNLOCK(stcb);
 	SCTP_TCB_LOCK_DESTROY(stcb);
 	SCTP_TCB_SEND_LOCK_DESTROY(stcb);
 	if (from_inpcbfree == SCTP_NORMAL_PROC) {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201311031400.rA3E0H4x090897>